Modify

Opened 14 years ago

Closed 5 weeks ago

Last modified 5 weeks ago

#6556 closed defect (fixed)

Preferences "OK", "Cancel", & "Help" buttons unclickable on Netbooks because of Screen Resolution

Reported by: rickmastfan67 Owned by: team
Priority: major Milestone:
Component: Core Version: tested
Keywords: Cc:

Description (last modified by GerdP)

Alright, I just installed JOSM onto my Netbook because I wanted to try out the liveGPS plugin with a GPS unit I have to see if I can do some tracing with it tomorrow.

The problem is that when I go into the Preferences menu (F12), I can't access the "OK", "Cancel", & "Help" buttons because they show up below my screen resolution which is: 1024x600.

Is it possible that this can be fixed? Because the only way to get out of the Preferences area is to hit the "X" button, so I can't save any changes. Screenshot will be attached in a few.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2011-07-04 01:31:38
Last Changed Author: stoecker
Revision: 4201
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2011-07-04 00:07:05 +0200 (Mon, 04 Jul 2011)
Last Changed Rev: 4201

Identification: JOSM/1.5 (4201 en)
Memory Usage: 37 MB / 494 MB (4 MB allocated, but free)
Java version: 1.6.0_25, Sun Microsystems Inc., Java HotSpot(TM) Client VM
Operating system: Windows 7

Attachments (1)

PreferencesProblem.png (103.8 KB ) - added by rickmastfan67 14 years ago.

Download all attachments as: .zip

Change History (11)

by rickmastfan67, 14 years ago

Attachment: PreferencesProblem.png added

comment:1 by akks, 14 years ago

Yes, in doesn`t even fit in 1024x768!

comment:2 by xeen, 14 years ago

Resolution: fixed
Status: newclosed

In [4248/josm]:

fix #6556

When the prefs are opened for the very first time, the window is now at most
as large as the parent window. After that, the dimensions are stored in JOSM's
preferences, so it won't work for existing installations.

As an additional measure, the dialog cannot be larger than the screen dimension
and as far as my testing goes this setting overwrites the stored dimension.
Unfortunately there is no way to determine the space occupied by application
launchers/taskbars across all systems and the pref dialog may be hidden behind
them.

comment:3 by xeen, 14 years ago

To solve your issue, you can either delete the existing preferences file in "(where ever windows hides this)\Application Data\JOSM" or you can resize the dialog manually like you would any other windows. This should work unless Microsoft changed resizing after Windows XP.

comment:4 by anonymous, 6 weeks ago

I have this issue using java2d.uiScale=2. I need to upscale for everything to be legible. Everything works fine but I cannot resize the preferences tab smaller than the screen. There should be a key in the advances preferences to override the minimum screen resolution for the preferences tab.

comment:5 by anonymous, 6 weeks ago

Resolution: fixed
Status: closedreopened

comment:6 by anonymous, 6 weeks ago

Looking at https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/gui/preferences/PreferenceDialog.java
line 57 this.setMinimumSize(new Dimension(800, 600));
With 2x scaling the dimension is doubled so that the minimum size now has a height of 1200 which is too big on my 1080p screen.
Is it possible to just edit the minimum size to be 400, 300 at least so that it is compatible with more devices?

comment:7 by GerdP, 5 weeks ago

Description: modified (diff)

I can reproduce the problem on my Windows laptop when I use a clean installation and

java-options=-Dsun.java2d.uiScale=2

in the cfg. BTW: when I click ESC and F12 again the dialog shows the lower part with the buttons.

To be honest, I don't know why we use the setMinimumSize() at all. For me, JOSM works fine when I remove the statement, both with and without the sun.java2d.uiScale=2. Maybe it is needed with other OS or older JRE?

comment:8 by anonymous, 5 weeks ago

The ESC then F12 does not work for me to show the lower part with buttons. I have to reset the scaling to 1x to see them.
I am on Debian Trixie, GNOME, Wayland and without any java options JOSM is scaled to 2x. I have fonts in GNOME settings set to 1.5x so I think my OS requests scaling and the number gets rounded up to 2x.

I don't know anything about java development, but setMinimumSize() is probably set to avoid edge cases where a window too small might cause crashes and divide by zero errors if the window was collapsed entirely. The safest option now would be to set the minimum size smaller to solve this problem on most displays while not introducing unintended bugs.

comment:9 by GerdP, 5 weeks ago

Resolution: fixed
Status: reopenedclosed

In 19447/josm:

fix #6556: Preferences "OK", "Cancel", & "Help" buttons unclickable on Netbooks because of Screen Resolution

  • reduce minimum dialog size

comment:10 by anonymous, 5 weeks ago

Just reporting that 19447 fixed my issue on Debian Trixie, GNOME, Wayland

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.