Modify

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#6542 closed enhancement (fixed)

[Patch] option to download relation without its members for "Download object" dialog

Reported by: Zverikk Owned by: team
Priority: major Milestone:
Component: Core Version: latest
Keywords: relation, download, related Cc:

Description (last modified by bastiK)

  1. Open "Download object" (Ctrl+Shift+O) dialog.
  2. For example, enter relation id 1439589 and uncheck all checkboxes (including "download related").
  3. Download.

What's expected: one downloaded relation
What's happened: one downloaded relation + 16 child relations + all ways in those 16 relations + all nodes for all ways in those relations.

Seems like "download related" checkbox does not work.

r4201

Also, is there a way for this example to download only parent relation + 16 child relations, without their members? It was the default behaviour about 400 builds ago with checked "download related".

Attachments (1)

6542.patch (7.0 KB) - added by simon04 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 in reply to:  description Changed 8 years ago by bastiK

Replying to Zverikk:

  1. Open "Download object" (Ctrl+Shift+O) dialog.
  2. For example, enter relation id 1439589 and uncheck all checkboxes (including "download related").
  3. Download.

What's expected: one downloaded relation
What's happened: one downloaded relation + 16 child relations + all ways in those 16 relations + all nodes for all ways in those relations.

Seems like "download related" checkbox does not work.

What is "download related"? Do you mean "download referrers"? Checking this option downloads parent relations / ways. Usually we get complains, when members are missing, so I think the current behaviour is best as default. We could add more option, but it gets a little complicated.

r4201

Also, is there a way for this example to download only parent relation + 16 child relations, without their members? It was the default behaviour about 400 builds ago with checked "download related".

Ctrl+L > http://api.openstreetmap.org/api/0.6/relation/1439589

then in Relationlist: Right click > Download members.

comment:2 Changed 8 years ago by anonymous

Same opinion as Zverikk - when I want only one relation and no members I should get only what I wanr. What is the purpose of the checkbox if the behavior of the programm is always the same - when the checkbox is checked and when iy is not... Try to work with relation that groups the borders of the regions of Russian Federation (83 relations with hundreds of members) and you will understand that it is hard to do it now, when I have to download ALL that stuff.

comment:3 Changed 8 years ago by bastiK

Summary: Download object -> download related checkbox does not workoption to download relation without its members for "Download object" dialog
Type: defectenhancement

The checkbox does change the program behaviour, but simply not in the way you expect. This option decides, whether parent ways and relations should be downloaded. Relation members and way nodes are always included, there is no checkbox for this.

Maybe there is a problem with the translation?

comment:4 in reply to:  3 Changed 8 years ago by simon04

Replying to bastiK:

Maybe there is a problem with the translation?

What about:

  • renaming "Download Referrers" to "Download Parent Relations" and
  • adding "Download Members" as additional option?

Changed 8 years ago by simon04

Attachment: 6542.patch added

comment:5 Changed 8 years ago by simon04

Summary: option to download relation without its members for "Download object" dialog[Patch] option to download relation without its members for "Download object" dialog

Patch attached:

  • renames "Download Referrers" to "Download referrers (parent relations and ways)"
  • introduces checkbox "Download relation members"

Please take a look at the patch!

comment:6 Changed 8 years ago by bastiK

Description: modified (diff)

"downloadprimitive.full" is not saved to preferences, but otherwise I see nothing wrong with this.

comment:7 Changed 8 years ago by simon04

Right, I'll add this and commit the changes afterwards.

comment:8 Changed 8 years ago by simon04

Resolution: fixed
Status: newclosed

In [4497/josm]:

fix #6542 - option to download relation without its members for "Download object" dialog

comment:9 Changed 8 years ago by Zverikk

I saw the result of this patch, and I now agree that I made an incorrect ticket: the downloaded relation is useless. It should be: "What's expected: one downloaded relation and 16 relations it references, without their members". In other words, there should be a single "download members" on that relation.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.