Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#6370 closed defect (fixed)

Reverter plugin is broken after core changes

Reported by: akks Owned by: Upliner
Priority: major Milestone:
Component: Plugin reverter Version:
Keywords: Cc:


Now Reverter plugin throws NullPointerException instead of downloading changeset.
The same plugin version works ok at with JOSM rev 3965 (no not know, what exct revision broke it)

Repository Root:
Build-Date: 2011-05-21 01:31:32
Last Changed Author: bastiK
Revision: 4091
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Date: 2011-05-20 11:39:10 +0200 (Fri, 20 May 2011)
Last Changed Rev: 4091

Identification: JOSM/1.5 (4091 ru)
Memory Usage: 47 MB / 989 MB (16 MB allocated, but free)
Java version: 1.6.0_23, Sun Microsystems Inc., Java HotSpot(TM) Client VM
Operating system: Windows XP
Dataset consistency test: No problems found

Plugin: reverter (25578)


at org.openstreetmap.josm.gui.progress.PleaseWaitProgressMonitor.close(
at reverter.RevertChangesetAction$1.checkAndDownloadMissing(
at reverter.RevertChangesetAction$1.realRun(
at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(
at java.util.concurrent.Executors$ Source)
at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source)
at Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$ Source)
at Source)

Attachments (0)

Change History (8)

comment:1 Changed 12 years ago by akks

4080 works, 4085 does not. Sorry, I have no more time these days..

Last edited 12 years ago by akks (previous) (diff)

comment:2 Changed 12 years ago by akks

Unfortunately, it's our 4081 - MultiFetchServerObjectReader changed its behaviour (?). Do not know how to repair.

Last edited 12 years ago by akks (previous) (diff)

comment:3 Changed 12 years ago by akks

Reverter works OK if I use 4081 revision and from 4080.
Stop working exactly after updating to 4081.

comment:4 Changed 12 years ago by bastiK

Resolution: fixed
Status: newclosed

Method signatures in MultiFetchServerObjectReader slightly changed, so plugin needed recompile [o26047]. NPE is a little strange, but should work now.

comment:5 Changed 12 years ago by akks

All works OK. There is also plugin TrustOSM that use MultiFetchServerObjectReader, but I do not know, is it working - it does not even compile due to some character encoding problem. After adding utf8 it cannot be built too. I added ticket for authors to notice the possible problem.

comment:6 Changed 12 years ago by skyper

Resolution: fixed
Status: closedreopened

I can not revert node 1221699249 or 1221699431 of changeset 7826133.

I get no message but the node is not moved back to previous position.

Repository Root:
Build-Date: 2011-06-02 01:31:20
Last Changed Author: stoecker
Revision: 4114
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Date: 2011-06-01 22:23:11 +0200 (Wed, 01 Jun 2011)
Last Changed Rev: 4114

Communications with established using protocol version 0.6.
loading plugin 'reverter' (version 26047)
Successfully loaded Bing attribution data.

Last edited 12 years ago by skyper (previous) (diff)

comment:7 Changed 12 years ago by Upliner

Resolution: fixed
Status: reopenedclosed

Fixed again by recompilation: [o26093]

comment:8 in reply to:  7 Changed 12 years ago by skyper

Replying to Upliner:

Fixed again by recompilation: [o26093]

Thanks a lot for the fast fix.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Upliner.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.