#6367 closed defect (fixed)
[PATCH]Select last node of way when undoing Follow Line
| Reported by: | Manchito | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 14.05 |
| Component: | Core | Version: | latest |
| Keywords: | undo follow line | Cc: |
Description (last modified by )
- Extend a line with Follow Line
- Undo the last action
- Try to use Follow Line again
- Crash
Attachments (2)
Change History (15)
Changed 13 years ago by
| Attachment: | undo_crash.patch added |
|---|
comment:1 Changed 13 years ago by
| Summary: | Crash when using Follow Line action after undo → [patch] Crash when using Follow Line action after undo |
|---|
comment:2 Changed 13 years ago by
Undo is a little strange for follow line:
- Press F a few times
- Ctrl-Z --> rubber line vanishes
- Ctrl-Z repeatedly until you reach the first node --> rubber line comes back and is attached to the (still selected) last node
I think it would be best, if undo moved the rubber line back node by node.
comment:4 Changed 13 years ago by
@Manchito:
Please no formatting changes in patches.
@bastiK:
That is an normal DrawAction issue, as the last node of a ChangeCommand stays selected. But currently we do not do real selection handling in Undo/Redo. I do not know if it is a good idea to introduce this. It could take a lot of memory and bring little benefits. But maybe we can link the existing SelectionHistory to Undo/Redo, so in case we have a selection history we can use it.
comment:5 Changed 12 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
| Summary: | [patch] Crash when using Follow Line action after undo → Select last node of way when undoing Follow Line (WAS:Crash when using Follow Line action after undo) |
| Type: | defect → enhancement |
Would be nice if the selected node would change to the last node of the way.
Right now I often only miss a "crossing" by one or two nodes and hit undo. If have to manually select the last node to continue drawing which means changing modes twice.
Thanks
comment:6 Changed 12 years ago by
| Summary: | Select last node of way when undoing Follow Line (WAS:Crash when using Follow Line action after undo) → Select last node of way when undoing Follow Line |
|---|---|
| Type: | enhancement → defect |
Letting the undo command select the last node is an expected behavior, doing not so is clearly a defect.
comment:7 Changed 12 years ago by
| Summary: | Select last node of way when undoing Follow Line → [PATCH]Select last node of way when undoing Follow Line |
|---|
With the new patch josm sets the selection to the last node after undoing Follow Line. Feel free to test it.
comment:8 Changed 11 years ago by
| Description: | modified (diff) |
|---|
This patch looks like it has been overlooked. Anyone tested it?
comment:11 Changed 10 years ago by
ping
This is really annoying and the patch is waiting over 21 month for review now.
comment:13 Changed 10 years ago by
| Milestone: | → 14.05 |
|---|
I think this patch fixes symptoms instead of real cause.