Modify

Opened 13 years ago

Closed 13 years ago

#6343 closed defect (fixed)

[Patch needs review] Relation windows don't remember their last position

Reported by: flaimo Owned by: Don-vip
Priority: normal Milestone:
Component: Core Version: tested
Keywords: Windows Cc:

Description (last modified by stoecker)

I am working with two monitors on my windows machine. Whenever I open up a window for a relation it pops up on the first screen, no matter where it was located the last time it was closed. this is cumbersome to work with, since I always have to drag the windows over to the second screen.

win 7, build 4064

Attachments (1)

patch.diff (3.8 KB ) - added by Don-vip 13 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by flaimo, 13 years ago

Summary: Reation windows don't remeber their last positionRelation windows don't remember their last position

comment:2 by malenki, 13 years ago

Can't confirm this one for my setup:
Debian sid,
LXDE with OpenBox

java version "1.6.0_25"
Java(TM) SE Runtime Environment (build 1.6.0_25-b06)
Java HotSpot(TM) 64-Bit Server VM (build 20.0-b11, mixed mode)

comment:3 by flaimo, 13 years ago

can someone else with a win 7 system try this too?

in reply to:  3 comment:4 by Don-vip, 13 years ago

Keywords: Windows added
Owner: changed from team to Don-vip
Status: newassigned

Replying to flaimo:

can someone else with a win 7 system try this too?

Same with me on r4475. I'll look into it.

comment:5 by Don-vip, 13 years ago

Description: modified (diff)
Summary: Relation windows don't remember their last position[Patch needs review] Relation windows don't remember their last position

OK, here's a working patch for Windows 7. We're in stabilization state, so I won't commit something that could break display on other systems until the next tested version is out. In the meanwhile, I'd like to know if someone can test it under Linux and Mac OS X. And some comments on the approach: should we have two applySafe methods, like in this patch (one for a single screen, one for mullti screens), or should we just modify the existing applySafe method to allow multi screen display ? (I'm afraid of possible side effects as this method is called very often).

by Don-vip, 13 years ago

Attachment: patch.diff added

comment:6 by stoecker, 13 years ago

Description: modified (diff)

Do you commit yourself?

comment:7 by Don-vip, 13 years ago

OK, I'll do that tomorrow :)

comment:8 by Don-vip, 13 years ago

Resolution: fixed
Status: assignedclosed

In [4571/josm]:

fix #6343 - Relation windows don't remember their last position

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.