Modify

Opened 10 years ago

Closed 9 years ago

#6245 closed defect (fixed)

Plugin utilsplugin2 has some shorcut conflicts with other plugins/JOSM core.

Reported by: rickmastfan67 Owned by: team
Priority: major Milestone:
Component: Plugin utilsplugin2 Version: latest
Keywords: Cc:

Description (last modified by akks)

Just noticed this today. One of the shortcut conflicts is with the "alignways" plugin. The other one is with the "measurement" plugin.

loading plugin 'utilsplugin2' <version 25876>
Silent shortcut conflict: 'menu:More tools' moved by 'subwindow:measurement' to 'Alt+B'.
Silent shortcut conflict: 'tools:intway' moved by 'tools:alignways' to 'Alt+Shift+I'.

Attachments (0)

Change History (24)

comment:1 Changed 10 years ago by stoecker

Component: PluginPlugin utilsplugin2

comment:2 Changed 10 years ago by rickmastfan67

Summary: Plugin utilsplugin2 has some shorcut conflicts with 2 other plugins.Plugin utilsplugin2 has some shorcut conflicts with other plugins/JOSM core.

Here's another conflict that utilsplugin2 has. But this time, it's with a core JOSM shortcut. Just discovered this one today.

Silent shortcut conflict: 'properties:add' moved by 'menu:More tools' to 'Alt+C'.

comment:3 in reply to:  2 Changed 10 years ago by rickmastfan67

Priority: normalmajor

Replying to rickmastfan67:

Here's another conflict that utilsplugin2 has. But this time, it's with a core JOSM shortcut. Just discovered this one today.

Silent shortcut conflict: 'properties:add' moved by 'menu:More tools' to 'Alt+C'.

After more investigating on this one, I've found out it's a perfect storm of plugins renaming shortcuts to have this happen. You would have to have michigan_left, measurement, and utilsplugin2 all installed and activated to have this happen.

Since the default 'properties:add' shortcut is 'Alt+B', it gets overridden by the first conflict you see mentioned in the original post. If you don't have michigan_left installed, it gets moved to 'Alt+Shift+M' and the problem with the #6282 gets created. When #6282 happens, the 'subwindow:measurement' forces 'properties:add' shortcut to 'Alt+C'. Then, 'properties:add' takes over 'Alt+C' (which is the shortcut for the 'subwindow:conflict') and thus forces 'subwindow:conflict' to 'Alt+Shift+C'.

All in all, a perfect storm of shortcut problems. Because of this, I'm upgrading this one to "major".

Here's what the CL says about all this when those three plugins only are active:

loading plugin 'michigan_left' <version 25190>
loading plugin 'utilsplugin2' <version 25912>
loading plugin 'measurement' <version 25199>
Silent shortcut conflict: 'menu:More tools' moved by 'subwindow:measurement' to 'Alt+B'.
< load data here >
Silent shortcut conflict: 'properties:add' moved by 'menu:More tools' to 'Alt+C'.
Silent shortcut conflict: 'subwindow:conflict' moved by 'properties:add' to 'Alt+Shift+C'.
Silent shortcut conflict: 'subwindow:mappaint' moved by 'tools:michigan_left' to 'Alt+D'.

So, if you want to close #6282 and deal with it all in this ticket, I'd understand.

comment:4 Changed 10 years ago by rickmastfan67

An update on this. In r4177, even with just utilsplugin2 installed, it has 4 "Silent shortcut conflicts" with JOSM core shortcuts. I mainly discovered this while trying to find out the conflicting plugin that #67 was being effected by. Anyways, here's the CL from r4177 with just utilsplugin2 being the only plugin installed:

loading plugin 'utilsplugin2' <version 26174>
<< Downloaded some data from OSM here >>
Silent shortcut conflict: 'mapmode:parallel' moved by 'tools:splitobject' to 'Alt+Shift+P'.
Silent shortcut conflict: 'subwindow:properties' moved by 'mapmode:parallel' to 'Alt+B'.
Silent shortcut conflict: 'properties:add' moved by 'subwindow"properties' to 'Alt+C'.
Silent shortcut conflict: 'subwindow:conflict' moved by 'properties:add' to 'Alt+Shift+C'.

comment:5 Changed 10 years ago by akks

It seems, there are no confilcts with core in 4186?

Alt-Shift-P= Parallel mode
Shift-P = split polygon
Alt-C = properties-add
Alt-Shift-C = confilcts panel

Conflict with alignways persists, but it is local plugin combination problem (just some rarely used keys are changed).

I think, we should change More Tools menu shortcut (not Alt-B) to fix subwindow:measurement.

comment:6 Changed 10 years ago by rickmastfan67

The conflict(s) is(are) still there in r4186. They only show up once you have download some data from the OSM servers or open a previously saved *.osm file.

Last edited 10 years ago by rickmastfan67 (previous) (diff)

comment:7 Changed 10 years ago by akks

OK, the conflict exists :)

I think it is time to move split polygon from Shift-P to some other hotkey.

comment:8 Changed 10 years ago by akks

Moved it to Ctrl-P, there are no conflicts now.

comment:9 Changed 10 years ago by akks

Resolution: fixed
Status: newclosed

comment:10 Changed 10 years ago by rickmastfan67

Resolution: fixed
Status: closedreopened

This shouldn't have been closed as it also deals with other conflicts that the utilsplugin2 plugin has with other plugins/JOSM core. Only the conflict with #67 is gone. All the other are still present in r4201.

comment:11 Changed 10 years ago by akks

I have moved 'More tools' shortcut to Ctrl-X. Only confict with AlignWays persists, but I do not think it needs a patch - there will be illogical shortcut and conflicts with other plugins.

I also think that AlignWays should be merged with Parallel Way in the core (not dragging the way, but ctrl- and shift- clicking ways, for example). Someone can create a ticket or patch.

comment:12 in reply to:  11 Changed 10 years ago by rickmastfan67

Replying to akks:

I have moved 'More tools' shortcut to Ctrl-X.

In what changeset? I didn't see the change on the OSM Trac today. Only saw the #6335 fix in [o26269].

comment:13 Changed 10 years ago by akks

In mixed plugin update the day before - [o26264], binary [o26265]. Next time I will add the revision number, thank you for example :)

Last edited 10 years ago by akks (previous) (diff)

comment:14 Changed 10 years ago by rickmastfan67

Ah, ok. ;) Missed that update the other day. ;)

BTW, it seems the plugin didn't get published correctly. I'm trying to download the [o26269] version from inside JOSM and it's not happening. JOSM keeps saying that [o26254] is the latest version of the plugin (which is what I have). Something similar to this happened with the undelete plugin a few days ago which I brought up in #6525.

comment:15 Changed 10 years ago by akks

Strange - the plugin is new, but version in jar-manifest is old :( Looking for reason...

comment:16 Changed 10 years ago by akks

Arr, I forget to do 'svn update' before publishing binary.
Correct way is commit source - build new jar - commit jar, yes? Strange system :)
Now it should work, if real old version is installed... (I hope)

Last edited 10 years ago by akks (previous) (diff)

comment:17 in reply to:  16 Changed 10 years ago by rickmastfan67

Replying to akks:

Arr, I forget to do 'svn update' before publishing binary.
Correct way is commit source - build new jar - commit jar, yes? Strange system :)
Now it should work, if real old version is installed... (I hope)

Update worked this time. ;)

On a side note, I just tested that new shortcut for the "More Tools" menu. Ctrl+X doesn't work for it. It seems to need to be an "Alt+(letter)" shortcut, at least in Windows. So, if the "More Tools" menu is to have a shortcut for it, it can only be the following letters in "Alt+*" (with the letter going where the star is): m o r e t l s. I don't know which ones are in use except for "T" (the "Tools" menu), "E" (the "Edit" menu), "S" (the "History" menu), and "M" (Measurement window). That would leave in theory, "o r l" as letters that could be used for the "More Tools" menu.

comment:18 Changed 10 years ago by anonymous

Alt-X works ( Xtended tools:) ), sorry for Ctrl-X (misspell). I can, of course, move it to Alt-O or Alt-R (Alt-L=Layers), but it would be less informative, especially considering many localizations.

comment:19 in reply to:  18 Changed 10 years ago by rickmastfan67

Replying to anonymous:

Alt-X works ( Xtended tools:) ), sorry for Ctrl-X (misspell). I can, of course, move it to Alt-O or Alt-R (Alt-L=Layers), but it would be less informative, especially considering many localizations.

Ah, "Alt+X". That does work here. ;)

Anyways, the reason why I was suggesting the other letters is because when you hit the "Alt" button, all the menu's have the letter that activates them underlined (example: "F" gets underlined in "File".) "More Tools" is the only one that doesn't have an underlined letter because there is no "x" in the name. ;) Hope you get what I'm talking about. ;)

comment:20 Changed 10 years ago by akks

Ok, ok, I will change it to Alt-R some time later. In my Russian JOSM I can only imagine this extraordinary effect ;)

comment:21 in reply to:  20 Changed 10 years ago by rickmastfan67

Replying to akks:

Ok, ok, I will change it to Alt-R some time later. In my Russian JOSM I can only imagine this extraordinary effect ;)

How was I suppose to know you are using the Russian version. :P

comment:22 Changed 10 years ago by rickmastfan67

Figures, there is a plugin that uses "Alt+R" that I didn't realize. :(

Silent shortcut conflict: 'menu:More Tools' moved by 'plugin:roadsigns:dialog' to 'Alt+B'.

But to be honest, I really have never used that plugin much (since the only set of signs in it is German), so I'm just going to deactivate it in my copy of JOSM to eliminate the conflict on my end. ;)

comment:23 Changed 9 years ago by akks

Description: modified (diff)

I think we can close this ticket, because there are no more conflicts with core.

comment:24 Changed 9 years ago by akks

Resolution: fixed
Status: reopenedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.