Modify

Opened 9 years ago

Closed 9 years ago

#6241 closed defect (fixed)

[PATCH] Validator plugin hangs

Reported by: akks Owned by: team
Priority: critical Milestone:
Component: Core validator Version: latest
Keywords: Cc:

Description

Test 12/19 causes plugin freeze... (unconnected lines)
osm-file attached

Attachments (3)

buggy.osm (422.1 KB) - added by akks 9 years ago.
river.osm (228.0 KB) - added by akks 9 years ago.
unconnectedNodes.patch (3.7 KB) - added by akks 9 years ago.
patch for speed-up

Download all attachments as: .zip

Change History (21)

comment:1 Changed 9 years ago by akks

Summary: Validator pluping hangsValidator plugin hangs

Changed 9 years ago by akks

Attachment: buggy.osm added

comment:2 Changed 9 years ago by stoecker

You're sure it freezes? Or is it only much slower as before, as it works again?

comment:2 Changed 9 years ago by akks

Correction: doest not hang but is VERY slow.
There are duplicated nodes, yes.

comment:3 Changed 9 years ago by akks

Few minutes to work on 2000 nodes and 44 ways.

Changed 9 years ago by akks

Attachment: river.osm added

comment:4 Changed 9 years ago by akks

Problem is 1184-node river. Splitting the way into 150-200 node fragments helps, but validation is still rather slow (~5 sec, 15 sec for single way). If more objects are loaded, time is too long to be patient enough)

Last edited 9 years ago by akks (previous) (diff)

comment:5 Changed 9 years ago by bilbo

It is unusably slow (on slightly weaker notebook with Atom on area with 2000 ways and 24000 nodes it took over 15 minutes and it was still working - after that I decided not to wait for something that could take perhapos hours and pressed cancel - and found out it does not respond to pressing the cancel button, so I had to kill JOSM)

comment:6 Changed 9 years ago by stoecker

Well, 15 minutes is too much. Probably we need a better data handling for large data sets and also fix the "cancel" problem.

comment:7 in reply to:  6 Changed 9 years ago by rickmastfan67

Replying to stoecker:

and also fix the "cancel" problem.

I agree, the "cancel" problem needs to be fixed. You can see an extreme case of it in #5973. Because of the "Cancel" problem, the download that is happening in it can't be stopped without either crashing Java (which kills JOSM) or by closing JOSM once you regain control of it by hitting the "X" button in the window.

comment:8 Changed 9 years ago by akks

Only 'unconnected lines' is slow. I turned it off in F12 - Validator properties for now.
All was OK few releases before.

comment:9 Changed 9 years ago by stoecker

Well, a few releases ago this test was effectively skipped due to a major bug :-)

comment:10 Changed 9 years ago by anonymous

I'm also having this problem, I'm trying to update the coastline with a fairly large edit. I've been waiting 30 mins so far... I'll turn off 'unconnected lines' next time but I'm going to have to wait for ages because I stupidly didn't bother saving before hitting the upload button.

comment:11 Changed 9 years ago by akks

Maybe autosave file is suitable? Search for it in AppData/JOSM, open in another JOSM windows and close old josm if all is OK)

comment:12 in reply to:  11 ; Changed 9 years ago by anonymous

Replying to akks:

Maybe autosave file is suitable? Search for it in AppData/JOSM, open in another JOSM windows and close old josm if all is OK)

You are a lifesaver! just saved me from loosing 2 hours work! All is there that I can see.

comment:13 in reply to:  12 Changed 9 years ago by anonymous

Replying to anonymous:

Replying to akks:

Maybe autosave file is suitable? Search for it in AppData/JOSM, open in another JOSM windows and close old josm if all is OK)

You are a lifesaver! just saved me from loosing 2 hours work! All is there that I can see.

By the way, it's still going... nearly 2 hours now.

comment:14 Changed 9 years ago by akks

I have made rather simple patch - replaced all HashSets with QuadBuckets and used end nodes for search instead of all dataset.
(And avoided function calls in 2 for-each loops).

Maybe it changes the behavior of tool - do not exactly know, but it is definetely faster and shows the same 11 unconnected ways warnings for neubrandenburg.osm .

Current configuration is absolutely unusable - we can not even stop the validation.

So please consider adding my patch before authors find some time to repair it more intelligent way.

Last edited 9 years ago by akks (previous) (diff)

Changed 9 years ago by akks

Attachment: unconnectedNodes.patch added

patch for speed-up

comment:15 Changed 9 years ago by akks

Summary: Validator plugin hangs[PATCH] Validator plugin hangs

comment:16 Changed 9 years ago by stoecker

In [4058/josm]:

see #6241 - patch by akks - improve long lasting validator check

comment:17 Changed 9 years ago by stoecker

Resolution: fixed
Status: newclosed

In [4059/josm]:

fix #6241 - add checks to breaking long running tests

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.