Opened 11 years ago
Last modified 2 years ago
#6102 new defect
Non-Connected way checks in validator needs to be projection independent
Reported by: | Nakor | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | Core validator | Version: | latest |
Keywords: | unconnected_way | Cc: |
Description (last modified by )
If you run validator the attached file in 3782 it correctly detects "Way end node near other highway".
In 3976 it does not detect it.
Attachments (2)
Change History (21)
Changed 11 years ago by
Attachment: | validator_bug.osm added |
---|
comment:1 Changed 11 years ago by
Component: | Core → Core validator |
---|
comment:2 Changed 11 years ago by
comment:3 Changed 11 years ago by
strange just some minutes ago it worked for some ways but now it does not.
comment:5 Changed 11 years ago by
Summary: | Validator won't detect non connected highways → Validator won't detect non connected highways anymore |
---|
3921 is OK
3925 has the bug
comment:7 Changed 11 years ago by
I tried to narrow it down to a precise revision:
- 3921 works fine
- 3922 is broken
comment:8 Changed 11 years ago by
Owner: | changed from team to Nakor |
---|---|
Status: | new → assigned |
Summary: | Validator won't detect non connected highways anymore → [patch] Validator won't detect non connected highways anymore |
@stoecker this is the reason. Attached is a patch that fixes the issue
comment:9 Changed 11 years ago by
Summary: | [patch] Validator won't detect non connected highways anymore → [incomplete patch] Validator won't detect non connected highways anymore |
---|
There is something more. The patch works on small examples but get stuck on big files.
comment:11 Changed 11 years ago by
The code depends on display projection. This is not really usable. It either should rely on direct LatLon calculations (e.g. greatCircleDistance() or force e.g. mercator projection for calculations.
comment:12 Changed 11 years ago by
Summary: | [incomplete patch] Validator won't detect non connected highways anymore → Non-Connected way checks in validator needs to be projection independent |
---|
comment:13 Changed 11 years ago by
Owner: | Nakor deleted |
---|---|
Status: | assigned → new |
comment:14 Changed 11 years ago by
Description: | modified (diff) |
---|---|
Keywords: | UnconnectedWays added |
comment:15 Changed 11 years ago by
Keywords: | unconnected_way added; UnconnectedWays removed |
---|
comment:18 Changed 2 years ago by
Not sure. Some calculation are still done with projecte values. What would be a good test case?
In r3992 it does not find any "way end node near other way" anymore.