Modify ↓

Opened 7 years ago

Last modified 6 years ago

#6102 new defect

Non-Connected way checks in validator needs to be projection independent

Reported by: Nakor Owned by:
Priority: major Milestone:
Component: Core validator Version: latest
Keywords: unconnected_way Cc:

Description (last modified by simon04)

If you run validator the attached file in 3782 it correctly detects "Way end node near other highway".

In 3976 it does not detect it.

Attachments (2)

validator_bug.osm​ (151.3 KB) - added by Nakor 7 years ago.
UnconnectedWays.diff​ (3.6 KB) - added by Nakor 7 years ago.
patch

Download all attachments as: .zip

Change History (17)

Changed 7 years ago by Nakor

Attachment: validator_bug.osm​ added

comment:1 Changed 7 years ago by skyper

Component: Core → Core validator

comment:2 Changed 7 years ago by skyper

In r3992 it does not find any "way end node near other way" anymore.

comment:3 Changed 7 years ago by skyper

strange just some minutes ago it worked for some ways but now it does not.

r4001

comment:4 Changed 7 years ago by Zibik

Hello

I have the same problem with validator...

comment:5 Changed 7 years ago by Nakor

Summary: Validator won't detect non connected highways → Validator won't detect non connected highways anymore

3921 is OK
3925 has the bug

comment:6 Changed 7 years ago by stoecker

NOTE: Error due to scaling factor change for mercator code?

comment:7 Changed 7 years ago by Nakor

I tried to narrow it down to a precise revision:

  • 3921 works fine
  • 3922 is broken

Changed 7 years ago by Nakor

Attachment: UnconnectedWays.diff​ added

patch

comment:8 Changed 7 years ago by Nakor

Owner: changed from team to Nakor
Status: new → assigned
Summary: Validator won't detect non connected highways anymore → [patch] Validator won't detect non connected highways anymore

@stoecker this is the reason. Attached is a patch that fixes the issue

comment:9 Changed 7 years ago by Nakor

Summary: [patch] Validator won't detect non connected highways anymore → [incomplete patch] Validator won't detect non connected highways anymore

There is something more. The patch works on small examples but get stuck on big files.

comment:10 Changed 7 years ago by stoecker

In [4034/josm]:

see #6102 - partial fix for nearby node checks

comment:11 Changed 7 years ago by stoecker

The code depends on display projection. This is not really usable. It either should rely on direct LatLon calculations (e.g. greatCircleDistance() or force e.g. mercator projection for calculations.

comment:12 Changed 7 years ago by stoecker

Summary: [incomplete patch] Validator won't detect non connected highways anymore → Non-Connected way checks in validator needs to be projection independent

comment:13 Changed 7 years ago by Nakor

Owner: Nakor deleted
Status: assigned → new

comment:14 Changed 6 years ago by simon04

Description: modified (diff)
Keywords: UnconnectedWays added

comment:15 Changed 6 years ago by simon04

Keywords: unconnected_way added; UnconnectedWays removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
The owner will change to Nakor
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from (none) to anonymous.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.