Modify

Opened 9 years ago

Closed 9 years ago

#5963 closed defect (fixed)

[patch] Relation editor fails to detect closed path

Reported by: Zverikk Owned by: team
Priority: major Milestone:
Component: Core Version: latest
Keywords: relation_analyzer, patch Cc: PetrDlouhy

Description

Download one of those relations: 1429033, 72196, 1111196. They consist of one closed path (made of several ways), but in relation editor those are not shown as closed. It was ok in tested version, I guess — it cannot be started after josm-latest, so I cannot test it. JOSM 3901.

Attachments (2)

relation_analysis.diff (1.0 KB) - added by PetrDlouhy 9 years ago.
patch fixing this bug
relation_analysis.osm (114.8 KB) - added by PetrDlouhy 9 years ago.
updated testing cases

Download all attachments as: .zip

Change History (11)

comment:1 Changed 9 years ago by stoecker

Cc: PetrDlouhy added

This is caused by the fact that there is a node in the relation. Seems this case is overlooked now.

comment:2 Changed 9 years ago by Zverikk

For relations with one node and multiple ways removing that node solves the problem indeed. But, for example, relation 1059483 not only has a node, but also an unconnected way — but all closed areas are detected and displayed as such.

Last edited 9 years ago by Zverikk (previous) (diff)

comment:3 Changed 9 years ago by PetrDlouhy

Keywords: relation_analyzer added

comment:4 Changed 9 years ago by Zverikk

More specific: closed path is not detected when a point is located (in the relation members order) inside or right after the area. For example: WWNWWWW (W=way,N=node) first path will be show as unclosed, second path — as closed. NWWWWWW (moving node to the head of the list) — both paths will be detected as closed.

Changed 9 years ago by PetrDlouhy

Attachment: relation_analysis.diff added

patch fixing this bug

Changed 9 years ago by PetrDlouhy

Attachment: relation_analysis.osm added

updated testing cases

comment:5 Changed 9 years ago by PetrDlouhy

I made patch for this issue. I tested only the case, I made for relation_analysis.osm, so please retest your relations.

Last edited 9 years ago by PetrDlouhy (previous) (diff)

comment:6 Changed 9 years ago by PetrDlouhy

Keywords: patch added
Summary: Relation editor fails to detect closed path[patch] Relation editor fails to detect closed path

comment:7 Changed 9 years ago by bastiK

Petr_Dlouhy: are you still working on the perfection of this tool? We are going to have a tested version soon, so it would be nice to see some improvement till then.

comment:8 Changed 9 years ago by PetrDlouhy

I haven't had enough time recently, but I might safe some time this weekend. I will take look on the remaining issues, but I can't promise to give it a large portion of work, if it became too complicated.

comment:9 Changed 9 years ago by bastiK

Resolution: fixed
Status: newclosed

In [3925/josm]:

fixed #5963 (patch by Petr_Dlouhy) - Relation editor fails to detect closed path

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.