Opened 14 years ago
Closed 14 years ago
#5927 closed defect (fixed)
[PATCH] Auto-complete is partially broken
Reported by: | rickmastfan67 | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core | Version: | latest |
Keywords: | Cc: |
Description (last modified by )
Steps to reproduce:
- Load (or create) any way/node and make sure it's selected.
- Click the "+Add" button to add a tag.
- Start typing a "key".
- Intentionally mistype the "key".
- Delete the mistyped part of the "key" and try to get auto-complete to finish the "key".
Expected results:
Auto-compete would give me at least one key (or value) for auto-completing.
What happens:
Auto-compete is broken and you have to manually finish typing the key (or value).
This happens in both the "key" and "value" boxes.
Example:
Here's a tag that you can easily do to verify the problem:
Type "n3" instead of "name" into the "key" box. When you delete the "3" and type "a" to trigger the auto-complete, it will not work.
This bug will not trigger as long as you don't misspell anything.
Repository Root: http://josm.openstreetmap.de/svn Build-Date: 2011-02-10 02:31:33 Last Changed Author: bastiK Revision: 3880 Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b URL: http://josm.openstreetmap.de/svn/trunk Last Changed Date: 2011-02-10 00:05:18 +0100 (Thu, 10 Feb 2011) Last Changed Rev: 3880 Identification: JOSM/1.5 (3880 en) Memory Usage: 340 MB / 455 MB (109 MB allocated, but free) Java version: 1.6.0_23, Sun Microsystems Inc., Java HotSpot(TM) 64-Bit Server VM Operating system: Windows 7
Attachments (1)
Change History (6)
comment:1 by , 14 years ago
Description: | modified (diff) |
---|
comment:2 by , 14 years ago
by , 14 years ago
Attachment: | josm_5876_2.patch added |
---|
comment:3 by , 14 years ago
ax, if you think the patch is ready to be approved by the main guys, you can go ahead and rename this topic with the word "PATCH" in it to get their attention. ;)
comment:4 by , 14 years ago
Summary: | Auto-complete is partially broken → [PATCH] Auto-complete is partially broken |
---|
how could i forget this? :)
this is a regression introduced with #5876 (by me :S). fix attached (rolling back my apparently incomplete "do we have to lookup this item again" test and using stoecker's quick fix instead). this fixes both #5876 and this bug (i tested shortly).
note that the autocomplete still isn't (and never was) 100% correct: there should be a completion offered already after the "3" is deleted, not only after you enter another "a". but, as stoecker said: "The AutoCompleteComboBox will never be 100% sure ...".