Opened 13 years ago

Closed 13 years ago

#5927 closed defect (fixed)

[PATCH] Auto-complete is partially broken

Reported by: rickmastfan67 Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Cc:

Description (last modified by rickmastfan67)

Steps to reproduce:

  1. Load (or create) any way/node and make sure it's selected.
  2. Click the "+Add" button to add a tag.
  3. Start typing a "key".
  4. Intentionally mistype the "key".
  5. Delete the mistyped part of the "key" and try to get auto-complete to finish the "key".

Expected results:
Auto-compete would give me at least one key (or value) for auto-completing.

What happens:
Auto-compete is broken and you have to manually finish typing the key (or value).

This happens in both the "key" and "value" boxes.

Here's a tag that you can easily do to verify the problem:
Type "n3" instead of "name" into the "key" box. When you delete the "3" and type "a" to trigger the auto-complete, it will not work.

This bug will not trigger as long as you don't misspell anything.

Repository Root:
Build-Date: 2011-02-10 02:31:33
Last Changed Author: bastiK
Revision: 3880
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Date: 2011-02-10 00:05:18 +0100 (Thu, 10 Feb 2011)
Last Changed Rev: 3880

Identification: JOSM/1.5 (3880 en)
Memory Usage: 340 MB / 455 MB (109 MB allocated, but free)
Java version: 1.6.0_23, Sun Microsystems Inc., Java HotSpot(TM) 64-Bit Server VM
Operating system: Windows 7

Attachments (1)

josm_5876_2.patch (1.8 KB) - added by ax 13 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 13 years ago by rickmastfan67

Description: modified (diff)

comment:2 Changed 13 years ago by ax

this is a regression introduced with #5876 (by me :S). fix attached (rolling back my apparently incomplete "do we have to lookup this item again" test and using stoecker's quick fix instead). this fixes both #5876 and this bug (i tested shortly).

note that the autocomplete still isn't (and never was) 100% correct: there should be a completion offered already after the "3" is deleted, not only after you enter another "a". but, as stoecker said: "The AutoCompleteComboBox will never be 100% sure ...".

Changed 13 years ago by ax

Attachment: josm_5876_2.patch added

comment:3 Changed 13 years ago by rickmastfan67

ax, if you think the patch is ready to be approved by the main guys, you can go ahead and rename this topic with the word "PATCH" in it to get their attention. ;)

comment:4 Changed 13 years ago by ax

Summary: Auto-complete is partially broken[PATCH] Auto-complete is partially broken

how could i forget this? :)

comment:5 Changed 13 years ago by bastiK

Resolution: fixed
Status: newclosed

In [3891/josm]:

fix #5927 - Auto-complete is partially broken (patch by ax)

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.