Modify

Opened 8 years ago

Closed 7 years ago

#5903 closed defect (fixed)

Presets: keys with required="true" are not any longer really required

Reported by: Fabi2 Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Cc:

Description (last modified by simon04)

Since the official "latest" of today (3849), e.g. checkboxes with required="true"
, are disabled by default, which means, that their key will not be added, if nothing other is selected. This is a really fresh bug, as it works until yesterday. This maybe a side effect of the escaping fix.

Example preset is attached.

Attachments (1)

preset-bug.xml (548 bytes) - added by Fabi2 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by Fabi2

Attachment: preset-bug.xml added

comment:1 Changed 8 years ago by Fabi2

This bug also affects bridge in the default presets.

            <combo key="bridge" text="Bridge" values="yes,viaduct,swing,aqueduct" required="true" default="yes" />

comment:2 Changed 8 years ago by bastiK

Did it ever work the way you expect? If yes, please check again and report the version.

(http://josm.openstreetmap.de/download/ has older versions, "required" was added in [3518].)

comment:3 Changed 8 years ago by Fabi2

I tried old versions also, which still did not work anymore after this bug was intruduced with the fix of the "\,"-Escaping for <combo>.

The are also the versions before the change was made affected, so this bug must be in the template which is dowloaded and used to parse the XML in the presets, as it worked as expected, before the ecaping fix was made.

comment:4 Changed 8 years ago by bastiK

Please state the version where it works as expected. I don't know what you mean by "downloaded template".

comment:5 in reply to:  4 Changed 8 years ago by Fabi2

Replying to bastiK:

Please state the version where it works as expected. I don't know what you mean by "downloaded template".

This one: http://josm.openstreetmap.de/tagging-preset-1.0, which is also used the standard presets.

As already said, I already tried to downgrade, but this works, when the file http://josm.openstreetmap.de/tagging-preset-1.0 is fetched over the network to parse the XML.

comment:6 Changed 7 years ago by simon04

Description: modified (diff)

As of r5068, required="true" is used only for matching primitives with presets, i.e, to determine whether the tags of the primitive correspond to the tags specified in the preset.

comment:7 Changed 7 years ago by simon04

Resolution: fixed
Status: newclosed

Subsumed by match since r5155.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.