Presets: keys with required="true" are not any longer really required

[Fabi2]

Since the official "latest" of today (3849), e.g. checkboxes with required="true"
, are disabled by default, which means, that their key will not be added, if nothing other is selected. This is a really fresh bug, as it works until yesterday. This maybe a side effect of the escaping fix.

Example preset is attached.

[Fabi2]

This bug also affects bridge in the default presets.

            <combo key="bridge" text="Bridge" values="yes,viaduct,swing,aqueduct" required="true" default="yes" />

[bastiK]

Did it ever work the way you expect? If yes, please check again and report the version.

(​http://josm.openstreetmap.de/download/ has older versions, "required" was added in [3518].)

[Fabi2]

I tried old versions also, which still did not work anymore after this bug was intruduced with the fix of the "\,"-Escaping for <combo>.

The are also the versions before the change was made affected, so this bug must be in the template which is dowloaded and used to parse the XML in the presets, as it worked as expected, before the ecaping fix was made.

[bastiK]

Please state the version where it works as expected. I don't know what you mean by "downloaded template".

[Fabi2]

Replying to bastiK:

Please state the version where it works as expected. I don't know what you mean by "downloaded template".

This one: ​http://josm.openstreetmap.de/tagging-preset-1.0, which is also used the standard presets.

As already said, I already tried to downgrade, but this works, when the file ​http://josm.openstreetmap.de/tagging-preset-1.0 is fetched over the network to parse the XML.

[simon04]

As of r5068, required="true" is used only for matching primitives with presets, i.e, to determine whether the tags of the primitive correspond to the tags specified in the preset.

[simon04]

Subsumed by match since r5155.