Modify

Opened 9 years ago

Closed 8 years ago

#5861 closed defect (fixed)

[Patch] Multiple ways in "via" for turn restrictions trigger "error" when validator is run when it shouldn't

Reported by: rickmastfan67 Owned by: team
Priority: major Milestone:
Component: Core validator Version: latest
Keywords: Cc:

Description

There is an interchange here in the Pittsburgh area on PA-28 where there is a left entrance ramp and almost immediately, there is a right hand exit and you're not allowed to cut across the highway from that left ramp to exit right away. When I set it up in JOSM, there are two ways between the two ramps (because of a bridge). So, I put the two ways in the "via" area to accomplish this restriction. The Turn Restriction plugin had no problems with doing this. However, when I went to upload, the automatic validation trigger and reported an "error" about "More than one "via" way found" as well as "The "to" way does not start or end at a "via" way".

This is the relation that you can see the problems on: http://www.openstreetmap.org/browse/relation/1380836

Now, when I do load the relation in the relation editor in JOSM, the entire route is connected, so I have no idea why I also get that "The "to" way does not start or end at a "via" way" error. And regarding the "More than one "via" way found" one, even the main relation page says you can use more than one way.

Now, I tagged this as the "Plugin validator" encase you can also fix this for people who can't upgrade to the 1.6 Java branch of JOSM. But I'm using r3790 with the validator built in. (so if you want to change the "Component" part, go ahead)

Just thought I would let you guys know of this major validator "error" bug.

Attachments (2)

5861.patch (8.9 KB) - added by simon04 8 years ago.
5861_v2.patch (9.5 KB) - added by simon04 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by simon04

Attachment: 5861.patch added

Changed 8 years ago by simon04

Attachment: 5861_v2.patch added

comment:1 Changed 8 years ago by simon04

Summary: Multiple ways in "via" for turn restrictions trigger "error" when validator is run when it shouldn't[Patch] Multiple ways in "via" for turn restrictions trigger "error" when validator is run when it shouldn't

The attached patch checks the following:

  • exactly one via node
  • at least one via way
  • via node/way not intermixed
  • via ways are connected among themselves and with from and to way (takes oneways into account)
  • _v2: via node is connected with from and to way (takes oneways into account)

comment:2 Changed 8 years ago by stoecker

The problem here is, that drawing code and validator are in sync. When we change validator, the drawing must also be changed.

comment:3 Changed 8 years ago by stoecker

Resolution: fixed
Status: newclosed

In [4370/josm]:

fix #5861 - patch by simon04 - validator warnings for multiple via ways

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.