Modify ↓

Opened 14 years ago

Closed 9 years ago

#5546 closed defect (fixed)

relation editor: copying mixes up sorting

Reported by: anonymous Owned by: team
Priority: normal Milestone: 16.02
Component: Core Version: latest
Keywords: relation editor, copy Cc:

Description

When copying some members from one relation editor window to another, the sorting is totally mixed up. Additionally, the copied members lose their roles during copying.

Attachments (0)

Change History (8)

comment:1 by mdk, 9 years ago

Drag & drop between two relations editors works fine (roles and order are preserved).
Copy & paste (CTRL-C and CTRL-V) do something, but as described above, roles and order get lost.
I think if this grid didn't support C&P, it should be disabled.

in reply to:  1 comment:2 by simon04, 9 years ago

Milestone: → 16.02

Replying to mdk:

Copy & paste (CTRL-C and CTRL-V) do something, but as described above, roles and order get lost.
I think if this grid didn't support C&P, it should be disabled.

This behaviour goes back to r3384 and might deserve an update :)

comment:3 by stoecker, 9 years ago

At that time relations probably had no guaranteed order yet. That was introduced later as far as I remember.

See ​Difference between API 0.5 and 0.6

Last edited 9 years ago by stoecker (previous) (diff)

comment:4 by mdk, 9 years ago

I think there are tree problems.

First the lost of the role. I think this should be fixed.

The second problem is the place where to insert: at the end or marking a place to insert or "sorting" or ... I don't know.

The third problem is that on Copy&Paste the order is reversed. Just prevent the revesing would help a lot, I think.

comment:5 by simon04, 9 years ago

In 9710/josm:

see #5546 - Relation editor: fix sorting when copying/pasting relation members

in reply to:  3 ; comment:6 by simon04, 9 years ago

Replying to stoecker:

At that time relations probably had no guaranteed order yet. That was introduced later as far as I remember.

HashSets aren't not perfect for keeping a specific sorting ;)

Since we are already discussing legacy things: is there a reason for a "custom" implementation of CopyAction and PasteAction in contrast to the ​Swing CCP? → #12478

Last edited 9 years ago by simon04 (previous) (diff)

in reply to:  6 comment:7 by stoecker, 9 years ago

Replying to simon04:

Since we are already discussing legacy things: is there a reason for a "custom" implementation of CopyAction and PasteAction in contrast to the ​Swing CCP? → #12478

I have no idea.

in reply to:  description comment:8 by simon04, 9 years ago

Resolution: → fixed
Status: new → closed

Replying to anonymous:

Additionally, the copied members lose their roles during copying.

→ #12565

So this one is fixed :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.