Modify

Opened 10 years ago

Closed 10 years ago

#5510 closed defect (fixed)

Trailing white space in Service URL leads to error

Reported by: Gubaer Owned by: team
Priority: major Milestone:
Component: Core imagery Version: latest
Keywords: Cc:

Description

  • Open preferences for WMS plugin
  • enter the URL http://glebius.int.ru/wms/irs? and append arbitrary white space (blanks, newlines)
  • click Get Layers

==>

  • Plugin can't retrieve layers from http://glebius.int.ru/wms/irs?

Suggested improvement

  • Remove trailing and leading white space in the Service URL before retrieving the list of available layers

Attachments (2)

ss-1.jpg (10.7 KB) - added by Gubaer 10 years ago.
Input of Service URL with trailing whitespace
ss-2.jpg (10.0 KB) - added by Gubaer 10 years ago.
error message

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Gubaer

Attachment: ss-1.jpg added

Input of Service URL with trailing whitespace

Changed 10 years ago by Gubaer

Attachment: ss-2.jpg added

error message

comment:1 Changed 10 years ago by Zverikk

Priority: minormajor

Also, siberiano reports that after copypasting TMS URL with a newline char at the end into the table, newline gets written to the preferences file, resulting in a blank line and "Preferences file had errors" on next startups. This is rather severe, I guess. We need to trim all input strings of spaces and newlines.

comment:2 Changed 10 years ago by stoecker

Resolution: fixed
Status: newclosed

In [4164/josm]:

fix #5510 - strip white space and return from WMS/TMS URLs

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.