Modify

Opened 9 years ago

Closed 9 years ago

#5430 closed defect (fixed)

"Select all" still activated while in AlignWays mode causing unexpected exception

Reported by: Emvee Owned by: tilusnet
Priority: minor Milestone:
Component: Plugin alignways Version: latest
Keywords: AlignWays, Select All Cc: tilusnet, Emvee

Description

Running JOSM version 3514 and AlignWayS version 22850, I did run into a problem because of an "operator error". I was in AlignWayS mode and by accident I did hit Ctrl-a instead of Shift-a and being zoomed in I did not notice I did select everything so immediately after Ctrl-a I hit Shift-a and then the problem happened. See also attached screen capture.

Error information:

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2010-09-06 01:31:24
Last Changed Author: stoecker
Revision: 3514
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2010-09-05 23:03:46 +0200 (Sun, 05 Sep 2010)
Last Changed Rev: 3514

Identification: JOSM/1.5 (3514 en)
Memory Usage: 133 MB / 494 MB (30 MB allocated, but free)
Java version: 1.6.0_21, Sun Microsystems Inc., Java HotSpot(TM) Client VM
Operating system: Windows XP
Dataset consistency test: No problems found

Plugin: PicLayer (22549)
Plugin: alignways (22850)
Plugin: buildings_tools (22904)
Plugin: remotecontrol (22734)
Plugin: routes (22590)
Plugin: validator (22805)
Plugin: wmsplugin (22964)

java.lang.NullPointerException at org.openstreetmap.josm.plugins.alignways.AlignWaysAction.actionValid(AlignWaysAction.java:88)
       at org.openstreetmap.josm.plugins.alignways.AlignWaysAction.actionPerformed(AlignWaysAction.java:59)
       at javax.swing.SwingUtilities.notifyAction(Unknown Source)
       at javax.swing.JComponent.processKeyBinding(Unknown Source)
       at javax.swing.KeyboardManager.fireBinding(Unknown Source)
       at javax.swing.KeyboardManager.fireKeyboardAction(Unknown Source)
       at javax.swing.JComponent.processKeyBindingsForAllComponents(Unknown Source)
       at javax.swing.JComponent.processKeyBindings(Unknown Source)
       at javax.swing.JComponent.processKeyEvent(Unknown Source)
       at java.awt.Component.processEvent(Unknown Source)
       at java.awt.Container.processEvent(Unknown Source)
       at java.awt.Component.dispatchEventImpl(Unknown Source)
       at java.awt.Container.dispatchEventImpl(Unknown Source)
       at java.awt.Component.dispatchEvent(Unknown Source)
       at java.awt.KeyboardFocusManager.redispatchEvent(Unknown Source)
       at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(Unknown Source)
       at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(Unknown Source)
       at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(Unknown Source)
       at java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source)
       at java.awt.Component.dispatchEventImpl(Unknown Source)
       at java.awt.Container.dispatchEventImpl(Unknown Source)
       at java.awt.Window.dispatchEventImpl(Unknown Source)
       at java.awt.Component.dispatchEvent(Unknown Source)
       at java.awt.EventQueue.dispatchEvent(Unknown Source)
       at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
       at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
       at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
       at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
       at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
       at java.awt.EventDispatchThread.run(Unknown Source)

Not a big deal, but probably better to fix.

Attachments (1)

AlignWayS_problem.jpg (23.8 KB) - added by Emvee 9 years ago.
Screen capture showing the problem situation

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by Emvee

Attachment: AlignWayS_problem.jpg added

Screen capture showing the problem situation

comment:1 Changed 9 years ago by stoecker

Component: PluginPlugin alignways
Owner: changed from team to tilusnet

comment:2 Changed 9 years ago by tilusnet

Status: newassigned

Yeah, it looks like JOSM's Select All may interfere with the plugins' own selection management. Disabling JOSM's Select All - or in fact all its selection related functionality - would be ideal, but I know no support for it.

Therefore the fix I'll commit soon will ignore all JOSM's selections if any, and instead the plugin will keep track of its own selections internally and use those only.

comment:3 Changed 9 years ago by tilusnet

Resolution: fixed
Status: assignedclosed

Fixed under revision 23082.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain tilusnet.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.