Modify

Opened 15 years ago

Closed 14 years ago

Last modified 14 years ago

#5380 closed defect (duplicate)

multipolygon plugin sets shortcut to "m"

Reported by: dieterdreist Owned by: bilbo
Priority: major Milestone:
Component: Core multipoly Version: latest
Keywords: shortcut Cc:

Description

multipolygon plugin sets shortcut to "m". This results in change for shortcut merge nodes.

Attachments (0)

Change History (11)

in reply to:  description comment:1 by dieterdreist, 15 years ago

Replying to dieterdreist:

multipolygon plugin sets shortcut to "m". This results in change for shortcut merge nodes.

Delete went from d to e (because of create multipolygon which is now on d). Please revert as well.

comment:2 by bilbo, 15 years ago

Shortcuts are settable in preferences - currently the shortcut is:
KeyEvent.VK_M, Shortcut.GROUP_EDIT, Shortcut.SHIFT_DEFAULT

Which should be usually Alt+shift+m, though some other plugins (like measurement plugin) likes to steal thet combination, but I never saw the plugin to falling back to only "M".

If "m" gets somehow assigned to multipoly, you can fix it in your preferences, in the keyboard shortcut section. I can't do anything to fix it in the plugin code.

comment:3 by bilbo, 15 years ago

Resolution: worksforme
Status: newclosed

Try setting the keys in preferences. If you find impossible to set the keys in preferences to match yuour desired keys, please open another bug.

comment:4 by bastiK, 15 years ago

Resolution: worksforme
Status: closedreopened

This is because multipoly-convert plugin has the same shortcut and JOSM's shortcut collision handling is a little strange...

comment:5 by bilbo, 15 years ago

Component: Plugin multipolyCore
Owner: changed from bilbo to team
Status: reopenednew

But then this is not problem in multipoly plugin but in JOSM shortcut handling system.

in reply to:  5 comment:6 by dieterdreist, 15 years ago

Replying to bilbo:

But then this is not problem in multipoly plugin but in JOSM shortcut handling system.

It is both IMHO: Plugin-Developers shouldn't use already in use shortcuts for new functions, and the shortcut-handling-system should first assign core-shortcuts and after that those for plugins (and not allow to reassign shortcuts automatically by plugins that are already assigned to core functions, but only manually).

comment:7 by stoecker, 14 years ago

Component: CorePlugin multipoly
Owner: changed from team to bilbo

in reply to:  7 ; comment:8 by skyper, 14 years ago

Replying to stoecker:

Has core been fixed to not automatically override shortcuts from core ?

Otherwise we should open another ticket to not forget about the issue.

in reply to:  8 comment:9 by skyper, 14 years ago

Replying to skyper:

Replying to stoecker:

Has core been fixed to not automatically override shortcuts from core ?

Has not.

Otherwise we should open another ticket to not forget about the issue.

#6341

comment:10 by skyper, 14 years ago

Resolution: duplicate
Status: newclosed

comment:11 by skyper, 14 years ago

Closed as duplicate of #5216.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain bilbo.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.