Improve mappaint style switch

[stoecker]

The possibility to switch a mappaint style during runtime between the loaded styles is broken. Now a restart is required.

[stoecker]

It seems named styles are broken completely.

[stoecker]

Named styles works, was my own error. Reason for broken style switch may be this: All the style caching I did has been moved into the primitive, but there is no check anymore to ensure we still have the right style. Either we need a caching or the cached styles must be cleared when the style is changed.

Additionally we could add a menu-point to choose styles, so it is no longer necessary to go to prefs.

[stoecker]

(In [3466]) see #5372 - fix missing style switch

[stoecker]

Two points as improvement missing (Jiri or Sebastian, can you do these, I did not get these done for long time):

• add JosmAction, which allows to switch style in toolbar (like search with parameter)
• add above action as menu entry (when more than one style is named?)
• add "resource://data/elemstyles.xml" in the styles-select-list as internal style
• better separate the style naming by an own table column, so people recognice we have that feature.

[bastiK]

I've done something like that already:

​http://github.com/bastik/josm/commit/ea2395df256f348ee2208bcdda864fd15f58f3de

But I'm not too happy with it, yet. It introduces a distinction between Base Styles and Extension Styles, but I'll probably revert that part.

[bastiK]

Replying to stoecker:

(In [3466]) see #5372 - fix missing style switch

I think this only does the current data layer

[stoecker]

(In [3467]) see #5372 - extend clean for all layers