Modify

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#5333 closed defect (fixed)

"Merge selection" tool is broken

Reported by: yohanson Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Have two layers
  2. Select an object
  3. Edit - Merge selection

What is the expected result?
Selected object is copied to another layer.

What happens instead?
Error message displayed.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2010-08-15 01:31:09
Last Changed Author: stoecker
Revision: 3438
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2010-08-15 00:34:57 +0200 (Sun, 15 Aug 2010)
Last Changed Rev: 3438

Identification: JOSM/1.5 (3438 ru)
Memory Usage: 226 MB / 494 MB (85 MB allocated, but free)
Java version: 1.6.0_18, Sun Microsystems Inc., OpenJDK 64-Bit Server VM
Operating system: Linux
Dataset consistency test: No problems found

Plugin: PicLayer (22549)
Plugin: buildings_tools (22529)
Plugin: fuzzer (15)
Plugin: measurement (22547)
Plugin: osmarender (21774)
Plugin: public_transport (22048)
Plugin: remotecontrol (22479)
Plugin: routing (22549)
Plugin: tageditor (21026)
Plugin: turnrestrictions (22477)
Plugin: wmsplugin (22581)

org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Complete node with null coordinates: {Node id=-1508 version=0 V }Unexpected error. Please report it to http://josm.openstreetmap.de/ticket/3892
{Node id=-1508 version=0 V }
Coor is null

	at org.openstreetmap.josm.data.osm.Node.setDataset(Node.java:132)
	at org.openstreetmap.josm.data.osm.DataSet.addPrimitive(DataSet.java:257)
	at org.openstreetmap.josm.data.osm.DataSet.getPrimitiveById(DataSet.java:627)
	at org.openstreetmap.josm.data.osm.visitor.MergeSourceBuildingVisitor.buildHull(MergeSourceBuildingVisitor.java:165)
	at org.openstreetmap.josm.data.osm.visitor.MergeSourceBuildingVisitor.build(MergeSourceBuildingVisitor.java:189)
	at org.openstreetmap.josm.actions.MergeSelectionAction.mergeSelected(MergeSelectionAction.java:39)
	at org.openstreetmap.josm.actions.MergeSelectionAction.actionPerformed(MergeSelectionAction.java:45)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2012)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2335)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:404)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
	at javax.swing.AbstractButton.doClick(AbstractButton.java:374)
	at javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:829)
	at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:873)
	at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
	at java.awt.Component.processMouseEvent(Component.java:6108)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3267)
	at java.awt.Component.processEvent(Component.java:5873)
	at java.awt.Container.processEvent(Container.java:2105)
	at java.awt.Component.dispatchEventImpl(Component.java:4469)
	at java.awt.Container.dispatchEventImpl(Container.java:2163)
	at java.awt.Component.dispatchEvent(Component.java:4295)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4461)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4125)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4055)
	at java.awt.Container.dispatchEventImpl(Container.java:2149)
	at java.awt.Window.dispatchEventImpl(Window.java:2478)
	at java.awt.Component.dispatchEvent(Component.java:4295)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:604)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:275)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:200)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:190)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:185)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:177)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:138)

Attachments (0)

Change History (5)

comment:1 Changed 11 years ago by bastiK

These complete nodes with null coordinates are really strange.

We should award a price to the one who can solve this riddle. ;)

comment:2 Changed 11 years ago by jttt

This one is my fault, I've added null cooor check directly to Node.setDataset(), but I didn't realize Dataset.getPrimitiveById(.., true) can legimately create such nodes.

comment:3 Changed 11 years ago by jttt

Resolution: fixed
Status: newclosed

(In [3440]) Fix #5333 "Merge selection" tool is broken

comment:4 Changed 11 years ago by anonymous

Ticket #5334 has been marked as a duplicate of this ticket.

comment:5 Changed 11 years ago by anonymous

Ticket #5337 has been marked as a duplicate of this ticket.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.