Opened 15 years ago
Closed 15 years ago
#5303 closed defect (worksforme)
JOSM removes all deleted nodes from local data set after upload, rather than only those that have been uploaded.
| Reported by: | Matthew Bell | Owned by: | Matthew Bell |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core | Version: | latest |
| Keywords: | Patch | Cc: |
Description
Attachments (4)
Change History (12)
by , 15 years ago
| Attachment: | 0001-Correct-method-and-variable-names.patch added |
|---|
by , 15 years ago
| Attachment: | 0002-Only-cleanup-uploaded-deleted-nodes.patch added |
|---|
by , 15 years ago
| Attachment: | 0003-Iterate-over-target-collection-instead-of-larger-col.patch added |
|---|
by , 15 years ago
| Attachment: | 0004-Whitespace.patch added |
|---|
comment:1 by , 15 years ago
| Version: | → latest |
|---|
comment:2 by , 15 years ago
| Summary: | JOSM removes all deleted nodes from local data set after upload, rather than only those that have been uploaded. → [PATCH] JOSM removes all deleted nodes from local data set after upload, rather than only those that have been uploaded. |
|---|
comment:3 by , 15 years ago
comment:4 by , 15 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → needinfo |
| Summary: | [PATCH] JOSM removes all deleted nodes from local data set after upload, rather than only those that have been uploaded. → JOSM removes all deleted nodes from local data set after upload, rather than only those that have been uploaded. |
Only partially applied. Please fix the remaining patches or close ticket when already fixed.
follow-up: 7 comment:5 by , 15 years ago
Oh come on, either apply them properly or not at all.
The patches in this ticket were based on r3416, which I believe was current when I posted them here. As noted, they were updated from the ones in the email. I've just checked them again and they apply cleanly. I have no idea why they don't apply for you; perhaps you need to apply them in the right order. I'm sorry, but I'm not going to clean up the mess you've made with that commit; it's really not that hard to merge patches if you've made conflicting changes in one or two commits.
comment:6 by , 15 years ago
Because inbetween SVn changed. You patches aren't the only ones. Try against newest SVN and you see they wont apply.
comment:7 by , 15 years ago
Replying to Matthew Bell:
Oh come on, either apply them properly or not at all.
The patches in this ticket were based on r3416, which I believe was current when I posted them here. As noted, they were updated from the ones in the email. I've just checked them again and they apply cleanly. I have no idea why they don't apply for you; perhaps you need to apply them in the right order. I'm sorry, but I'm not going to clean up the mess you've made with that commit; it's really not that hard to merge patches if you've made conflicting changes in one or two commits.
Please don't take it personal. It is always easier for the author of the patch to fix things than for the one who happens to commit it. And Stoecker hasn't made any mess that you could clean up. He simply applied 2 patches that where submitted before your's. It's not his job to fix subsequent contributions.
comment:8 by , 15 years ago
| Resolution: | → worksforme |
|---|---|
| Status: | needinfo → closed |
These are now based on latest SVN head.