Modify

Opened 11 years ago

Closed 11 years ago

#5303 closed defect (worksforme)

JOSM removes all deleted nodes from local data set after upload, rather than only those that have been uploaded.

Reported by: Matthew Bell Owned by: Matthew Bell
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Patch Cc:

Description


Attachments (4)

0001-Correct-method-and-variable-names.patch (3.0 KB) - added by Matthew Bell 11 years ago.
0002-Only-cleanup-uploaded-deleted-nodes.patch (2.3 KB) - added by Matthew Bell 11 years ago.
0003-Iterate-over-target-collection-instead-of-larger-col.patch (1.2 KB) - added by Matthew Bell 11 years ago.
0004-Whitespace.patch (4.7 KB) - added by Matthew Bell 11 years ago.

Download all attachments as: .zip

Change History (12)

Changed 11 years ago by Matthew Bell

Changed 11 years ago by Matthew Bell

Changed 11 years ago by Matthew Bell

Attachment: 0004-Whitespace.patch added

comment:1 Changed 11 years ago by Matthew Bell

Version: latest

These are now based on latest SVN head.

comment:2 Changed 11 years ago by stoecker

Summary: JOSM removes all deleted nodes from local data set after upload, rather than only those that have been uploaded.[PATCH] JOSM removes all deleted nodes from local data set after upload, rather than only those that have been uploaded.

comment:3 Changed 11 years ago by stoecker

(In [3426]) see #5303 - some cleanup patches from matthew Bell - partially applied only

comment:4 Changed 11 years ago by stoecker

Owner: changed from team to Matthew Bell
Status: newneedinfo
Summary: [PATCH] JOSM removes all deleted nodes from local data set after upload, rather than only those that have been uploaded.JOSM removes all deleted nodes from local data set after upload, rather than only those that have been uploaded.

Only partially applied. Please fix the remaining patches or close ticket when already fixed.

comment:5 Changed 11 years ago by Matthew Bell

Oh come on, either apply them properly or not at all.

The patches in this ticket were based on r3416, which I believe was current when I posted them here. As noted, they were updated from the ones in the email. I've just checked them again and they apply cleanly. I have no idea why they don't apply for you; perhaps you need to apply them in the right order. I'm sorry, but I'm not going to clean up the mess you've made with that commit; it's really not that hard to merge patches if you've made conflicting changes in one or two commits.

comment:6 Changed 11 years ago by stoecker

Because inbetween SVn changed. You patches aren't the only ones. Try against newest SVN and you see they wont apply.

comment:7 in reply to:  5 Changed 11 years ago by bastiK

Replying to Matthew Bell:

Oh come on, either apply them properly or not at all.

The patches in this ticket were based on r3416, which I believe was current when I posted them here. As noted, they were updated from the ones in the email. I've just checked them again and they apply cleanly. I have no idea why they don't apply for you; perhaps you need to apply them in the right order. I'm sorry, but I'm not going to clean up the mess you've made with that commit; it's really not that hard to merge patches if you've made conflicting changes in one or two commits.

Please don't take it personal. It is always easier for the author of the patch to fix things than for the one who happens to commit it. And Stoecker hasn't made any mess that you could clean up. He simply applied 2 patches that where submitted before your's. It's not his job to fix subsequent contributions.

comment:8 Changed 11 years ago by stoecker

Resolution: worksforme
Status: needinfoclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Matthew Bell.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.