Modify

Opened 9 years ago

Closed 9 years ago

#5276 closed defect (fixed)

[PATCH] Preset/Icon for man_made=flagpole

Reported by: jcollie Owned by: ce
Priority: normal Milestone:
Component: Internal preset Version:
Keywords: Cc:

Description

Here's a patch and icon for man_made=flagpole

Attachments (2)

flagpole.diff (1.6 KB) - added by jcollie 9 years ago.
patch
flagpole.png (457 bytes) - added by jcollie 9 years ago.
icon

Download all attachments as: .zip

Change History (11)

Changed 9 years ago by jcollie

Attachment: flagpole.diff added

patch

Changed 9 years ago by jcollie

Attachment: flagpole.png added

icon

comment:1 Changed 9 years ago by bastiK

Component: CoreInternal preset
Owner: changed from team to ce
Summary: Preset/Icon for man_made=flagpole[PATCH] Preset/Icon for man_made=flagpole

comment:2 Changed 9 years ago by ce

Resolution: fixed
Status: newclosed

(In [3391]) fixes #5276 Current build is broken so I cannot test whether the preset tags the elements correctly and whether the nodes are shown in the viewport with the correct icon. I assume yes for both.

comment:3 Changed 9 years ago by bastiK

Resolution: fixed
Status: closedreopened

Does not work.

Build is not broken, JOSM source is in Java 6, now.

comment:4 Changed 9 years ago by jcollie

Is there a reason that the key was changed to man_made=flagpost? As far as I can tell man_made=flagpost is not used whereas man_made=flagpole has 89 uses. Also why was the icon I provided not used? The "presets/flag.png" is a 32x32 icon which is larger than the 16x16 icons generally used on the map.

comment:5 Changed 9 years ago by ce

Resolution: fixed
Status: reopenedclosed

(In [3395]) preset icon cut to 32x32. added mapstyle icon 16x16. adjusted elemstyles accordingly. fixes #5276

comment:6 Changed 9 years ago by bastiK

Why is this icon so big (32x32)? Normally mappaint icons are smaller.

comment:7 Changed 9 years ago by bastiK

Resolution: fixed
Status: closedreopened

see above

comment:8 Changed 9 years ago by ce

The tag is set correctly now, the mappaint icon has been separated by the presets icon and shows up at a size of 16px as mappaint icons sould do.

May I ask which problem still persists?

comment:9 Changed 9 years ago by bastiK

Resolution: fixed
Status: reopenedclosed

Sorry, it's alright. I guess I had an old version in my local svn when I tested it...

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain ce.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.