Modify

Opened 14 years ago

Closed 13 years ago

#5257 closed enhancement (fixed)

[Patch] Automatic fix to Reversed water

Reported by: e2jk Owned by: team
Priority: normal Milestone:
Component: Core validator Version: tested
Keywords: Cc:

Description

A counter-clockwise closed way with natural=water will generate the following error:

Reversed water: land not on left side

The fix for this error is to reverse the direction of the way. Currently there is no proposed automatic fix, so you need to select all those errors and click on the "Reverse the direction of all selected ways" button.

I believe this could be automatically fixed.

JOSM 3376
Validator 22204

Attachments (1)

5257.patch (6.4 KB ) - added by simon04 13 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 by simon04, 13 years ago

According to the wiki (http://wiki.openstreetmap.org/wiki/Tag:natural=water), the orientation of natural=water does not matter. So remove testing natural=water?

comment:2 by simon04, 13 years ago

Btw: In WronglyOrderedWays there was is a minor bug when determining the orientation of a way, i.e., being (anti)clockwise. The problem is that the pair (last node of way, first node of way) is not taken into account.

The patch fixes this issue and reorganizes some code (e.g., provides Geometry.isClockwise(Way)).

by simon04, 13 years ago

Attachment: 5257.patch added

comment:3 by Casiope, 13 years ago

Summary: Automatic fix to Reversed water[Patch] Automatic fix to Reversed water

comment:4 by stoecker, 13 years ago

Resolution: fixed
Status: newclosed

In [4344/josm]:

fix #5257 - patch by simon04 - fix way order validator checks

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.