Modify

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#4827 closed defect (fixed)

Tags longer than 255 are not prohibit

Reported by: h4ck3rm1k3 Owned by: team
Priority: major Milestone:
Component: Core Version: latest
Keywords: tag length Cc:

Description

Please extend the validator to check for tags longer than 255 chars.
The validator option to merge nodes at the same position produced results that I could not use, then it is hard to even select those again.

Attachments (0)

Change History (11)

comment:1 by skyper, 15 years ago

Keywords: tag length added
Priority: minormajor

I noticed this quite some time ago, but I did not try to upload a tag with this length. see #4662 which is also not nice.

I think JOSM should not allow to add more than 255 chars at all. You could have a check with validator, but I think this is not needed as there are no longer tags on the server and if JOSM does not allow to add more than 255 chars, you would not get any warnings.

comment:2 by skyper, 15 years ago

Summary: Tags longer than 255 are not checkedTags longer than 255 are not prohibit
Type: enhancementdefect

comment:3 by skyper, 15 years ago

Component: Core validatorCore

comment:4 by anonymous, 15 years ago

Ticket #4843 has been marked as a duplicate of this ticket.

in reply to:  1 comment:5 by skyper, 15 years ago

Replying to skyper:

I think JOSM should not allow to add more than 255 chars at all. You could have a check with validator, but I think this is not needed as there are no longer tags on the server and if JOSM does not allow to add more than 255 chars, you would not get any warnings.

We need both. Prohibit it from adding and the validator check, because there can be merged layers which were not edited with josm, but you upload with josm and this will not work.

comment:6 by stoecker, 15 years ago

Ticket #5065 has been marked as a duplicate of this ticket.

comment:7 by stoecker, 15 years ago

Fixed in [o21440].

comment:8 by stoecker, 15 years ago

Resolution: fixed
Status: newclosed

I don't like to prohibit longer tags at all, as JOSM can be used for other purposes as well. We aren't that tightly tied to the OSM database.

comment:9 by skyper, 15 years ago

Then we need at least a validator check, and have JOSM refuse to upload to OSM if a tag is longer then 255 chars.

comment:10 by stoecker, 15 years ago

You've seen comment #7?

in reply to:  10 comment:11 by skyper, 15 years ago

Replying to stoecker:

You've seen comment #7?

Sorry, I was a bit to fast, but did really prohibit to upload tags with more than 255 chars to OSM ? or do you just warn on upload ?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.