Modify

Opened 15 years ago

Closed 14 years ago

#4761 closed defect (fixed)

Invalid warning about unclosed multipolygon

Reported by: delta_foxtrot2 Owned by: team
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: multipolygon warning Cc:

Description

The validator plugin should check to see if all members are present in a multipolygon before warning about it being unclosed.

Attachments (2)

4761.osm (4.9 KB ) - added by simon04 14 years ago.
example
4761.patch (1.2 KB ) - added by simon04 14 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by skyper, 15 years ago

Keywords: multipolygon warning added
Version: latest

by simon04, 14 years ago

Attachment: 4761.osm added

example

by simon04, 14 years ago

Attachment: 4761.patch added

comment:2 by simon04, 14 years ago

Summary: Invalid warning about unclosed multipolygon[Patch] Invalid warning about unclosed multipolygon

Fixed in the attached patch.

Last edited 14 years ago by simon04 (previous) (diff)

comment:3 by simon04, 14 years ago

Summary: [Patch] Invalid warning about unclosed multipolygonInvalid warning about unclosed multipolygon

Sorry, submitted the patch to the wrong ticket. Nevertheless, the attached example contains unclosed ways, but doesn't reveal this bug. I think, this fixed in the meanwhile, isn't it?

The following snipped from MultipolygonTest should take care of not warning about unclosed+incomplete multipolygons.

for (RelationMember rm : r.getMembers()) {
    if (!rm.getMember().isUsable())
        return; // Rest of checks is only for complete multipolygons
}
Last edited 14 years ago by simon04 (previous) (diff)

comment:4 by simon04, 14 years ago

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.