NPE when joining two buildings

[bilbo]

How to reproduce:
Load attached file into JOSM. Select both buildings and press Shift+J (Join overlapping aread) to attempt to merge these buildings into one building -> Failure with this exception

Build-Date: 2010-02-11 02:30:56		
Revision: 2964
Is-Local-Build: true

Memory Usage: 560 MB / 989 MB (160 MB allocated, but free)
Java version: 1.6.0_17, Sun Microsystems Inc., Linux

Dataset consistency test:
No problems found


Plugins: openstreetbugs,wmsplugin,tracer,remotecontrol,buildings_tools,validator,terracer2,graphview,multipoly,measurement
Plugin openstreetbugs Version: 19463
Plugin wmsplugin Version: 19626
Plugin tracer Version: 19927
Plugin remotecontrol Version: 19471
Plugin buildings_tools Version: 30
Plugin validator Version: 19688
Plugin terracer2 Version: ${version.entry.commit.revision}
Plugin graphview Version: 19441
Plugin measurement Version: 19681
Plugin multipoly Version: 19456

org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Osm id cannot be changed after primitive was added to the dataset
	at org.openstreetmap.josm.data.osm.OsmPrimitive.cloneFrom(OsmPrimitive.java:968)
	at org.openstreetmap.josm.data.osm.Way.cloneFrom(Way.java:224)
	at org.openstreetmap.josm.command.ChangeCommand.executeCommand(ChangeCommand.java:37)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:51)
	at org.openstreetmap.josm.data.UndoRedoHandler.addNoRedraw(UndoRedoHandler.java:38)
	at org.openstreetmap.josm.data.UndoRedoHandler.add(UndoRedoHandler.java:58)
	at org.openstreetmap.josm.actions.JoinAreasAction.commitCommands(JoinAreasAction.java:436)
	at org.openstreetmap.josm.actions.JoinAreasAction.joinAreas(JoinAreasAction.java:193)
	at org.openstreetmap.josm.actions.JoinAreasAction.actionPerformed(JoinAreasAction.java:166)
	at javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1633)
	at javax.swing.JComponent.processKeyBinding(JComponent.java:2839)
	at javax.swing.KeyboardManager.fireBinding(KeyboardManager.java:267)
	at javax.swing.KeyboardManager.fireKeyboardAction(KeyboardManager.java:229)
	at javax.swing.JComponent.processKeyBindingsForAllComponents(JComponent.java:2916)
	at javax.swing.JComponent.processKeyBindings(JComponent.java:2908)
	at javax.swing.JComponent.processKeyEvent(JComponent.java:2802)
	at java.awt.Component.processEvent(Component.java:6040)
	at java.awt.Container.processEvent(Container.java:2041)
	at java.awt.Component.dispatchEventImpl(Component.java:4630)
	at java.awt.Container.dispatchEventImpl(Container.java:2099)
	at java.awt.Component.dispatchEvent(Component.java:4460)
	at java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1850)
	at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:712)
	at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:990)
	at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:855)
	at java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:676)
	at java.awt.Component.dispatchEventImpl(Component.java:4502)
	at java.awt.Container.dispatchEventImpl(Container.java:2099)
	at java.awt.Window.dispatchEventImpl(Window.java:2475)
	at java.awt.Component.dispatchEvent(Component.java:4460)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:599)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

[bilbo]

Testcase to trigger bug

[Gubaer]

Classifying as critical for the next release because it affects a basic editing feature.

[bastiK]

It is an external plugin.
There is not much we can do about it

[Upliner]

As far as I see bug isn't in buildings_tools plugin, but in JoinAreasAction. It can be reproduced even when buildings_tools plugin is disabled.

[Gubaer]

As far as I see bug isn't in buildings_tools plugin, but in JoinAreasAction. It can
be reproduced even when buildings_tools plugin is disabled.

I second that. That's why I flagged it as r-2010-01-blocker. Didn't analyse it yet, though.

[bastiK]

sorry, you are right

[Gubaer]

Can't reproduce in r2974

• loaded the attached file
• selected both buildings
• pressed Shift-J

=> Everything is fine.

Closing as invalid.

Please reopen if you have additional examples.