Modify

Opened 10 years ago

Closed 8 years ago

#4439 closed defect (fixed)

[Patch] droping spaces in keys or value automatically

Reported by: vsandre Owned by: team
Priority: normal Milestone:
Component: Core Version: tested
Keywords: Cc:

Description

At the moment josm drops spaces at the end of a key or value only in the properties dialogue. This service should be extended for entries in the presets or relation editor.

Attachments (1)

4439.patch (32.9 KB) - added by simon04 8 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by anonymous

Keywords: r-2010-01-blocker added

comment:2 Changed 10 years ago by Gubaer

Keywords: r-2010-01-blocker removed

Please log in or leave your email address to flag a ticket as release blocker.

comment:3 Changed 10 years ago by Gubaer

Resolution: fixed
Status: newclosed

(In [3013]) fixed #4439: droping spaces in keys or value automatically

comment:4 Changed 10 years ago by anonymous

Resolution: fixed
Status: closedreopened

works for relation editor but not for presets.

Changed 8 years ago by simon04

Attachment: 4439.patch added

comment:5 Changed 8 years ago by simon04

Summary: droping spaces in keys or value automatically[Patch] droping spaces in keys or value automatically

This should be fixed in the attached patch.

I took the opportunity to remove a lot of duplicate code inside TaggingPreset by combining common parts of Combo and MultiSelect in a new abstract class ComboMultiSelect.

comment:6 Changed 8 years ago by stoecker

NOTE to team: This will need proper review, as handling of tagging presets is easily broken.

@simon04: Please continue with this speed until all JOSM core bugs are fixed ;-)

comment:7 Changed 8 years ago by stoecker

Resolution: fixed
Status: reopenedclosed

In [4340/josm]:

fix #4439 - patch by simon04 - remove useless spaces in tagging presets, remodeduplicate code - please report regressions in tagging presets if there are any

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.