Modify

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#4417 closed defect (fixed)

[PATCH] Code Page of Russian internal Help not correct

Reported by: calibrator Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: russian help font Cc:

Description

JOSM 2879. Code Page of Russian internal Help not correct. Please change Code Page.

Attachments (3)

JOSM_HelpPage.JPG (230.6 KB) - added by anonymous 10 years ago.
utf8.2.patch (755 bytes) - added by Upliner 10 years ago.
utf8.patch (755 bytes) - added by Upliner 10 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 10 years ago by calibrator

It's need: Unicode UTF-8

comment:2 Changed 10 years ago by stoecker

Owner: changed from team to calibrator
Status: newneedinfo

Please explain what you mean. Your request is not understandable at all. Everything in JOSM is or should be UTF-8.

Changed 10 years ago by anonymous

Attachment: JOSM_HelpPage.JPG added

comment:3 Changed 10 years ago by anonymous

See attached file? please. It is my PrintScreen Russian version Internal Help Page in JOSM.

comment:4 Changed 10 years ago by calibrator

It is CP1251 coding... See attached file.

comment:5 Changed 10 years ago by Upliner

This is because default Russian charset in Windows is cp1251. Maybe, specifying charset explicitly in ContentType can help? However, I cannot check this because I use Linux and don't have this problem at all.

Changed 10 years ago by Upliner

Attachment: utf8.2.patch added

Changed 10 years ago by Upliner

Attachment: utf8.patch added

comment:6 Changed 10 years ago by Upliner

Oh, content-type was not to blame. The bug occurs because InputStreamReader reads content in system default charset. It should read it in utf-8. I've updated the patch

comment:7 Changed 10 years ago by Upliner

Owner: changed from calibrator to team
Status: needinfonew
Summary: Code Page of Russian internal Help not correct[PATCH] Code Page of Russian internal Help not correct

I've just tested this patch in Windows machine and it works.

comment:8 Changed 10 years ago by Gubaer

Resolution: fixed
Status: newclosed

(In [2900]) applied #4417: patch by Upliner: Code Page of Russian internal Help not correct

comment:9 Changed 10 years ago by stoecker

NOTE: There may be some other issues like that. I already fixed equal issues for plugins, preferences file, bookmarks and the XML files.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.