Opened 13 years ago

Closed 12 years ago

#4274 closed defect (fixed)

[PATCH] Folders for File > Open...

Reported by: bastiK Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Cc:


Since r2703 you can open images using File > Open...

As a consequence it is allowed to open a entire folder: Then all images are extracted recursively.

However if the folder contains no images, an empty image layer is silently created.

A better way would be to also load all other file types recursively. (And maybe give a warning if it would result in many layers being created.)

I would do this myself, but have I no time till mid January.

Attachments (1)

josm-empty-image-layer.diff (899 bytes) - added by bomm 12 years ago.
patch to avoid empty image layer

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by bomm

Attachment: josm-empty-image-layer.diff added

patch to avoid empty image layer

comment:1 Changed 12 years ago by bomm

Summary: Folders for File > Open...[PATCH] Folders for File > Open...

I added a patch to throw an exception if no image file was found.
This will display an error message and prevent the creation of an empty image layer.

Checking how many layers would be created by recursively processing all file types without actually creating them would probably require a check function in every FileImporter.
I think if we really want this, it might be better to do the directory recursion outside of the FileImporter subclasses.

comment:2 Changed 12 years ago by stoecker

Resolution: fixed
Status: newclosed

(In [2799]) don't create empty image layer - closes #4274 - patch by bomm

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.