doubleclicking a relation should open its properties

[richlv]

currently doubleclicking a relation selects its elements.
instead, this action should open relation properties, without changing the selection.

rationale :

1. current selection is immediately lost;
2. relation elements can easily be selected from the relation properties anyway (and it provides more flexibility)

with the current behaviour i have lost complex selection several times when i have only wanted to look at properties of some other relation (to determine how to best tag)

[stoecker]

WONTFIX: When you lost selections, then don't double click. And there is a selection history you can use.

Double click to select is consistent over multiple dialogs.

[anonymous]

i really can't agree with that.

1. this is actually inconsistent. if we click a relation in the element properties area, relation's properties are opened - as expected.

2. this non-intuitive. if an object has properties screen, in absolute majority of cases the properties are opened (not looking at josm as an isolated case, but application concepts in general).

3. this makes working with relations harder, at least for me. most often i want to open relation properties, not select it's elements - that operation i perform much less often.

if you still do not agree with the points above, feel free to close again, thanks.

[stoecker]

We have selection dialog, history dialog, validator dialog and many others and all do select on click. Relation dialog did open edit in the past and it was changed to reach consistency.

[iandees]

I spoke with richlv on IRC today and suggested that the default double-click behavior for the Relations section could be changed to show the Relation Editor dialog rather than to select the relation. This would be consistent with the double-click behavior in the Membership part of the Properties/Memberships section. I'd be happy to supply a patch for this when I get home from work.

[richlv]

so, a sumary of thoughts, developed on this subject during this time :)

1. with a node or way selected, clicking on a relation in the "properties/memberships" block opens relation properties. this expectation is broken in the relation list;
2. doubleclicking a relation in the list currently only gives access to its tags. a relation has more properties than a way or node, namely - members. these properties can only be edited in the relation properties dialog. thus not opening relation properties gives us limited access to relation editing. why not open properties, thus allowing to do proper editing (tags are accessible there as well) ?

the only slight inconvenience is additional "ok" user would have to click after dealing with the relation, but i'd gladly take that over not being able to edit most relation properties in the default mode anyway.

3. the only way to open relation properties currently is to select a relation in the list by clicking on it once (!), then clicking on the "edit" button (which isn't even labeled, so i always have to pause for a moment before choosing it). that is, except by doubleclicking on the relation in the "properties/memberships" block...

during last couple of years i either think very hard where i click on relations, or constantly doubleclick them in relation list - which seriously slows down any work with relations, of course... so i'd like to ask for a second consideration on this usability change :)