slippymap: snapping to tile size cause runtimeerrors

[Bürste]

If you click on snap to tile size (which is else not translated yet) causes an runtimeerror:

Repository Root: ​http://josm.openstreetmap.de/svn
Build-Date: 2009-11-18 02:32:06
Last Changed Author: stoecker
Revision: 2468
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: ​http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2009-11-17 17:33:31 +0100 (Tue, 17 Nov 2009)
Last Changed Rev: 2468

Memory Usage: 63 MB / 508 MB (14 MB allocated, but free)
Java version: 1.6.0_03

Plugins: AgPifoJeditgpxnearclickopenvisibleremotecontrolslippymaptageditortagging-preset-testerterracervalidatorwaydownloaderwmsplugin
Plugin AgPifoJ Version: 18593
Plugin editgpx Version: 18595
Plugin nearclick Version: 17705
Plugin openvisible Version: 17536
Plugin remotecontrol Version: 18678
Plugin slippymap Version: 18593
Plugin tageditor Version: 18522
Plugin tagging-preset-tester Version: 14015
Plugin terracer Version: 17874
Plugin validator Version: 18623
Plugin waydownloader Version: 18617
Plugin wmsplugin Version: 18671

java.lang.NullPointerException

at org.openstreetmap.josm.plugins.slippymap.SlippyMapLayer$7.actionPerformed(SlippyMapLayer.java:216)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.AbstractButton.doClick(Unknown Source)
at javax.swing.plaf.basic.BasicMenuItemUI.doClick(Unknown Source)
at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

[Bürste]

As far as I can see this function doesn't work at all, so I deactivate it in rev18727.

[bastiK]

This was added recently and used to work.

It is an essential feature, so it should be fixed instead!

[bastiK]

Btw. it works fine here:

Build-Date: 2009-11-21 01:14:34		
Revision: 2485
Is-Local-Build: true

Memory Usage: 61 MB / 396 MB (36 MB allocated, but free)
Java version: 1.6.0_14

Plugins: openstreetbugsslippymapvalidatorwmsplugin
Plugin openstreetbugs Version: 18595
Plugin slippymap Version: 18593
Plugin validator Version: 18623
Plugin wmsplugin Version: 18712

Maybe update the josm version?

[anonymous]

I've committed a fix for this and applied in osm SVN revision 18731.

If you want to work around this for now, turn on tile autoloading off autozooming and avoid snapping to tile size right after zoom level changes.

[bastiK]

thx,
however the change by Bürste is not reverted yet.

(Also the binary needs to be committed (maybe later :) ))

[hansendc]

I'll leave it to Bürste to undo his own patch.

[Bürste]

@hansendc
Feel free to undo my changes if needed, but a user should not get such errors. So if you fix it it should be stable.

@bastiK
I didn't get the function to run so ... what is it doing that it is essential?

I never wanted to block further develop, but on the next build it should be stable or not part of it, I think.

[hansendc]

@Bürste . I created a bug, and I fixed it. You removed a feature and *you* need to fix it, please.

[stoecker]

In [o18784].