Modify

Opened 14 years ago

Closed 14 years ago

#3842 closed defect (wontfix)

Validator: closed coastline is not always an island

Reported by: mjulius Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: Cc:

Description

The validator flags all closed, clockwise coastlines as "Reversed coastline: land not on left side". This incorrectly assumes that every closed coastline must be an island.

While it might not be best practice it is not an error to tag pieces of water in this way. In fact, there are many PGS coastlines that are like that. However, I agree that those coastlines should be fixed.

I would propose to downgrade the error to a warning and call it "Clockwise coastline" or similar. Without an extensive analysis of the surrounding coastlines it is difficult for the validator to decide whether it is an island that should be reversed or water that should be tagged natural=water or so.

Attachments (0)

Change History (3)

in reply to:  description comment:1 by Daeron, 14 years ago

Replying to mjulius:

The validator flags all closed, clockwise coastlines as "Reversed coastline: land not on left side". This incorrectly assumes that every closed coastline must be an island.

No, closed coastlines must be islands. If a body of water is mapped as a closed way, it should not be tagged as natural=coastline, but as natural=water

While it might not be best practice it is not an error to tag pieces of water in this way. In fact, there are many PGS coastlines that are like that. However, I agree that those coastlines should be fixed.

Yes, it is an error, the coastline error checker http://wiki.openstreetmap.org/wiki/Coastline_error_checker will mark them as errors.

I would propose to downgrade the error to a warning and call it "Clockwise coastline" or similar. Without an extensive analysis of the surrounding coastlines it is difficult for the validator to decide whether it is an island that should be reversed or water that should be tagged natural=water or so.

It's definitely an error and shouldn't be downgraded to a warning. The wording however could be changed, but is there enough room or some other way to include tips that it probably should be tagged as natural=water if it's lake etc.?

comment:2 by mjulius, 14 years ago

Ticket #2830 has been marked as a duplicate of this ticket.

comment:3 by stoecker, 14 years ago

Resolution: wontfix
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.