Modify

Opened 10 years ago

Closed 8 years ago

#3736 closed enhancement (fixed)

[Patch awaiting end of stabilization phase] Split Crossing Ways test into Crossing Ways and Crossing Waterways

Reported by: avarab@… Owned by: team
Priority: normal Milestone:
Component: Core validator Version: latest
Keywords: Cc: mohler@…

Description

Waterways should cross other ways (e.g. highways) without having connecting nodes. They should be left out of the crossing ways test.

Attachments (2)

crossing-ways-ford.osm (1.8 KB) - added by avarab@… 10 years ago.
ways crossing on a ford
3736.patch (1.3 KB) - added by simon04 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by anonymous

Use layer! Waterway also can be on bridge or in tunnel.

comment:2 Changed 10 years ago by stoecker

Resolution: wontfix
Status: newclosed

When a waterway crosses a street on same layer something is wrong. Usually a bridge is missing. So this test is perfectly valid and data should be fixed.

comment:3 in reply to:  2 Changed 10 years ago by avarab@…

Resolution: wontfix
Status: closedreopened
Summary: Leave waterways out of Crossing Ways testSplit Crossing Ways test into Crossing Ways and Crossing Waterways
Type: defectenhancement

Replying to stoecker:

When a waterway crosses a street on same layer something is wrong. Usually a bridge is missing. So this test is perfectly valid and data should be fixed.

Actually a layer=* is missing. It'll still flag it if there's a bridge and no layer=* tag on either objects.

In any case I'd like to reopen this as an enhancement request and ask that when ways are crossing and one of them is a waterway=* that it be reported under another category (Crossing Waterways).

Usually Crossing Ways that aren't waterways are errors in the data like a self-overlapping highway made from GPX data, or two residential streets that cross but don't share a node. Those errors are important and can screw up routing, but crossing waterways without a layer=* are something that's handled by all the renderers and no other user of the data really cares about.

comment:4 Changed 10 years ago by LamoniDave

Cc: mohler@… added

Perhaps just a JOSM beginner question, but in the case where a road fords a waterway, would both be at the same "layer"? After all, the road traveler's (car, biker, walker, etc.) tires/ shoes/ feet "hit the road" at the same level as the water from the waterway. Is this a case where "a waterway crosses a street on the same layer" where something is not wrong? Should this produce an error? Or is there another way to represent a ford that should address this problem?

comment:5 in reply to:  4 Changed 10 years ago by avarab@…

Replying to LamoniDave:

Perhaps just a JOSM beginner question, but in the case where a road fords a waterway, would both be at the same "layer"? After all, the road traveler's (car, biker, walker, etc.) tires/ shoes/ feet "hit the road" at the same level as the water from the waterway. Is this a case where "a waterway crosses a street on the same layer" where something is not wrong? Should this produce an error? Or is there another way to represent a ford that should address this problem?

If the waterway and road meet with a highway=ford node then crossing ways won't complain. But if there's a highway=ford way over the waterway then the test will be triggered.

I'm attaching a test file which demonstrates this.

Changed 10 years ago by avarab@…

Attachment: crossing-ways-ford.osm added

ways crossing on a ford

Changed 8 years ago by simon04

Attachment: 3736.patch added

comment:6 Changed 8 years ago by simon04

Summary: Split Crossing Ways test into Crossing Ways and Crossing Waterways[Patch awaiting end of stabilization phase] Split Crossing Ways test into Crossing Ways and Crossing Waterways

comment:7 Changed 8 years ago by simon04

Resolution: fixed
Status: reopenedclosed

In [4678/josm]:

fix #3736 - Split Crossing Ways test into Crossing Ways and Crossing Waterways

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.