Modify

Opened 15 years ago

Closed 13 years ago

#3721 closed enhancement (wontfix)

Default to GTK look and feel on Linux systems

Reported by: anonymous Owned by: anonymous
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Cc: mathieu.tl@…

Description (last modified by simon04)

Josm currently uses the Java metal look and feel by default on Linux. In the interest of UI consistency with other applications, I've written a patch to make it default to the GTK+ look and feel on Linux.

This bug was initially reported on Launchpad, but #441619, here:
https://bugs.launchpad.net/ubuntu/+source/josm/+bug/441619

Attachments (4)

josm-default-laf-setting-linux.patch (877 bytes ) - added by mathieu.tl@… 15 years ago.
default laf to GTK on Linux
josm-default.png (149.1 KB ) - added by avarab@… 15 years ago.
JOSM default style
josm-gtk.png (149.4 KB ) - added by avarab@… 15 years ago.
JOSM gtk style
gtk+laf.png (101.8 KB ) - added by bastiK 15 years ago.

Download all attachments as: .zip

Change History (16)

by mathieu.tl@…, 15 years ago

default laf to GTK on Linux

comment:1 by mathieu.tl@…, 15 years ago

Cc: mathieu.tl@… added

My bad, forgot to set the email when reporting the bug.

comment:2 by vsandre, 15 years ago

Summary: Default to GTK look and feel on Linux systems[Patch] Default to GTK look and feel on Linux systems

comment:3 by xeen, 15 years ago

Owner: changed from team to anonymous
Status: newneedinfo
Summary: [Patch] Default to GTK look and feel on Linux systemsDefault to GTK look and feel on Linux systems

Can we really assume that "WINDOWS" or "LINUX" are at the beginning of the OS string? Old version searched for it anywhere in the string, so can either verfiy or modify the patch please?

comment:4 by stoecker, 15 years ago

Actually that check should be moved to the OS hooks completely!

comment:5 by stoecker, 15 years ago

Resolution: wontfix
Status: needinfoclosed

Cleanup in r2371. WONTFIX, as GTK style wastes too much space especially in sidebar.

in reply to:  5 ; comment:6 by avarab@…, 15 years ago

Replying to stoecker:

Cleanup in r2371. WONTFIX, as GTK style wastes too much space especially in sidebar.

I think the GTK+ style looks crappy since it's a bad emulation of a proper GTK look, but on my system/GTK versions does it use too much space?

On my GTK (2.16.1-0ubuntu2) the toolbar which contains 21 icons and 7 spacers is horizontally wider by the equivalent of 1/2 a single icon width under GTK.

Under GTK the sidebar icons take up the equivalent of 1/10 (or less) icon space vertically and horizontally the GTK sidebar takes up noticeably less space, leaving more for the map area.

Perhaps you're using some unusual GTK+ skin that takes up too much space?

in reply to:  6 comment:7 by avarab@…, 15 years ago

Replying to avar:

Replying to stoecker:

Cleanup in r2371. WONTFIX, as GTK style wastes too much space especially in sidebar.

I think the GTK+ style looks crappy since it's a bad emulation of a proper GTK look, but on my system/GTK versions does it use too much space?

Should be "but on what system..."

by avarab@…, 15 years ago

Attachment: josm-default.png added

JOSM default style

by avarab@…, 15 years ago

Attachment: josm-gtk.png added

JOSM gtk style

by bastiK, 15 years ago

Attachment: gtk+laf.png added

comment:8 by bastiK, 15 years ago

Resolution: wontfix
Status: closedreopened

The GTK laf integrates much better for me. (I have a custom skin.)

I would like to have it as default, as well.

However I don't know how KDE users feel about it...


comment:9 by bastiK, 15 years ago

(In [2391]) improved Toolbar to the left:

  • removed strange left margin (in Metal L&F, see #3721: josm-default.png)
  • show scroll-buttons only if necessary
  • allow mousewheel scrolling

comment:10 by Candid Dauth, 15 years ago

Hm, the GTK look does not really work here in JOSM 2255. All GUI elements have no borders, so I cannot see where I can click. Some GUI elements such as arrows aren’t displayed either.

comment:11 by simon04, 13 years ago

Description: modified (diff)

I personally prefer the Metal L&F and I don't see a big deal as the L&F can easily be configured. I'd stick to the current selection.

comment:12 by stoecker, 13 years ago

Resolution: wontfix
Status: reopenedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain anonymous.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.