Modify

Opened 14 years ago

Closed 13 years ago

#3665 closed enhancement (fixed)

Showing waypoints with name and note/comment

Reported by: mmehl Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: waypoints Cc: michael.mehl@…

Description

While mapping I sometimes create a waypoint and add a note/comment to this way point.
It would be nice to see the name and the note/comment when loading the waypoints into JOSM.

The patch below, adds the note/comment, if a comment is available.

Index: src/org/openstreetmap/josm/gui/layer/markerlayer/Marker.java
===================================================================
--- src/org/openstreetmap/josm/gui/layer/markerlayer/Marker.java (revision 2252)
+++ src/org/openstreetmap/josm/gui/layer/markerlayer/Marker.java (working copy)
@@ -117,6 +117,10 @@

String name_desc = "";
if (wpt.attr.containsKey("name")) {

name_desc = wpt.getString("name");

+ if (wpt.attr.containsKey("desc")) {
+ name_desc+=", ";
+ name_desc+=wpt.getString("desc");
+ }

} else if (wpt.attr.containsKey("desc")) {

name_desc = wpt.getString("desc");

}

Attachments (1)

WaypointWithComment.diff (788 bytes ) - added by mmehl 14 years ago.
Patch

Download all attachments as: .zip

Change History (11)

by mmehl, 14 years ago

Attachment: WaypointWithComment.diff added

Patch

comment:1 by mmehl, 14 years ago

Cc: michael.mehl@… added

comment:2 by mmehl, 14 years ago

Summary: Showing waypoints with name and note/comment[Patch] Showing waypoints with name and note/comment

comment:3 by mmehl, 14 years ago

Summary: [Patch] Showing waypoints with name and note/comment[PATCH] Showing waypoints with name and note/comment

comment:4 by stoecker, 14 years ago

I'm not really sure that this is the right approach. What if some devices add automated comments and users get a cluttered display due to much useless stuff.

comment:5 by Gubaer, 14 years ago

Resolution: fixed
Status: newclosed

(In [2280]) applied #3665: patch by mmehl: Showing waypoints with name and note/comment

comment:6 by andrewpmk, 14 years ago

My device (Garmin Legend HCx) appears to add the date/time as comment. Could you please add a toggle in preferences so that this isn't too distracting?

comment:7 by anonymous, 14 years ago

Resolution: fixed
Status: closedreopened

The usability of this feature is not yet optimal (see remarks of stoecker and andrewpmk).
I don't think preferences are a good solution, because typical preferences are used as a compromise, when no better solution is found.

Maybe something like showing more details when clicking (or mouse over) on the waypoint ...

comment:8 by stoecker, 14 years ago

(In [2295]) reverted r2280, see #3665

comment:9 by stoecker, 14 years ago

Summary: [PATCH] Showing waypoints with name and note/commentShowing waypoints with name and note/comment

comment:10 by mjulius, 13 years ago

Resolution: fixed
Status: reopenedclosed

I believe this has been fixed in r3396.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.