Showing waypoints with name and note/comment

[mmehl]

While mapping I sometimes create a waypoint and add a note/comment to this way point.
It would be nice to see the name and the note/comment when loading the waypoints into JOSM.

The patch below, adds the note/comment, if a comment is available.

Index: src/org/openstreetmap/josm/gui/layer/markerlayer/Marker.java
===================================================================
--- src/org/openstreetmap/josm/gui/layer/markerlayer/Marker.java (revision 2252)
+++ src/org/openstreetmap/josm/gui/layer/markerlayer/Marker.java (working copy)
@@ -117,6 +117,10 @@

String name_desc = "";
if (wpt.attr.containsKey("name")) {

name_desc = wpt.getString("name");

+ if (wpt.attr.containsKey("desc")) {
+ name_desc+=", ";
+ name_desc+=wpt.getString("desc");
+ }

} else if (wpt.attr.containsKey("desc")) {

name_desc = wpt.getString("desc");

}

[mmehl]

Patch

[stoecker]

I'm not really sure that this is the right approach. What if some devices add automated comments and users get a cluttered display due to much useless stuff.

[Gubaer]

(In [2280]) applied #3665: patch by mmehl: Showing waypoints with name and note/comment

[andrewpmk]

My device (Garmin Legend HCx) appears to add the date/time as comment. Could you please add a toggle in preferences so that this isn't too distracting?

[anonymous]

The usability of this feature is not yet optimal (see remarks of stoecker and andrewpmk).
I don't think preferences are a good solution, because typical preferences are used as a compromise, when no better solution is found.

Maybe something like showing more details when clicking (or mouse over) on the waypoint ...

[stoecker]

(In [2295]) reverted r2280, see #3665

[mjulius]

I believe this has been fixed in r3396.