Modify

Opened 13 years ago

Closed 13 years ago

#3544 closed defect (fixed)

[PATCH] Search history remembers only last item

Reported by: saingularita@… Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

Since recent builds it seems the search history remembers only the last item and not 10 items as it was before. Seem there are no preferences related to the search that I could possibly screw up, so I guess that is a bug.

Attachments (2)

shfix.patch (1.5 KB) - added by bilbo 13 years ago.
bugfix + settable history size
search-fix.patch (743 bytes) - added by bilbo 13 years ago.
Fix this completely

Download all attachments as: .zip

Change History (7)

comment:1 Changed 13 years ago by bilbo

I found the cause. When search settings is stored in history, a reference to object is stored instead of copy and then it is later modified by search dialog as new search is started (and therefore the searched string will be always the same as the first in history)

Attached patch fixes this.

Also, the default search history size (10 items) is IMHO small, so I have also added a setting to make it ocnfigurable (with 10 items as default)

Changed 13 years ago by bilbo

Attachment: shfix.patch added

bugfix + settable history size

comment:2 Changed 13 years ago by bastiK

Summary: Search history remembers only last item[PATCH] Search history remembers only last item

comment:3 Changed 13 years ago by stoecker

Resolution: fixed
Status: newclosed

(In [2226]) fixed #3544 - patch by singularita gmail com - fix search dialog history

comment:4 Changed 13 years ago by bilbo

Resolution: fixed
Status: closedreopened

Found out this was not fixed properly - you must also store copy of SearchSettings in lastSearch variable.

Now you can search for A, then for B, then for C, then you select B from history, then you search for D - and B is replaced by D in history (history is now A, D, C, D)

Attached patch fixes that

Changed 13 years ago by bilbo

Attachment: search-fix.patch added

Fix this completely

comment:5 Changed 13 years ago by stoecker

Resolution: fixed
Status: reopenedclosed

(In [2262]) applied #3544 - fix search history - patch by singularita gmail com

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.