Modify

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#3441 closed enhancement (fixed)

[patch] When reselecting a node/way cycle the selection to other ways that particular way/node is a member of

Reported by: ramilehti Owned by: xeen
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Cc: xeen

Description

It should be as easy as possible to select things in JOSM.
To make it easy as possible make it so that
when you reselect a node or a way it cycles through the list of ways and areas that that particular node or way is a member of.
The current middle click the control click is hard to do especially when you have a node or a way that is a part of three or more ways. (Two landuses and a residential road for example)

Attachments (3)

middle_click_patch.patch (18.9 KB ) - added by xeen 15 years ago.
2009-09-12-233138_1276x762_scrot.png (83.7 KB ) - added by xeen 15 years ago.
The colors depend on your system settings. I've set mine to black, too, but here's a screenshot from Windows in its retro design. Haven't checked for Luna or Glass. Also didn't try for Mac or Linux w/ Gnome or KDE. The colors *should* depend on the theme, though. Or at least on the chosen LookAndFeel in the options dialog.
Screenshot.png (17.2 KB ) - added by stoecker 15 years ago.
This is KDE3.5 with Metal as display style. in JOSM

Download all attachments as: .zip

Change History (9)

comment:1 by stoecker, 15 years ago

Cc: xeen added

Coders note:
Currently we reselect already selected elements to allow stability in selection. Improvement could be:

  • First click - do as done now
  • Further clicks select the next entry in selectable possibilities
  • Longer click delay goes back to normal mode

Question: How to handle multiple selections?

xeen - I add you as CC, have you time for a nice solution?

comment:2 by xeen, 15 years ago

Owner: changed from team to xeen

I'll see what I can do about it. I'm still concerned though that this might be confusing if the user actually wants to select multiple elements, i.e. the road and the landuse. Same issue if the user accidentally selected something and now wants to deselect. Well, I'll have a look.

by xeen, 15 years ago

Attachment: middle_click_patch.patch added

comment:3 by xeen, 15 years ago

Summary: When reselecting a node/way cycle the selection to other ways that particular way/node is a member of[patch] When reselecting a node/way cycle the selection to other ways that particular way/node is a member of

This patch doesn't change anything at the SelectAction, but takes another route. For one, handling the selection properly for every mode would be a lot of effort given that SelectAction is quite large already (~500 lines of code) and I couldn't think of a proper way to allow the user to select both (e.g. when there's a tram line painted directly over a street). (Plus timed solutions require training before they can be executed with a low error rate, making it frustrating especially for less used features).

For two, JOSM already features middle click just for that reason, so I (tried to) improve the middle click feature. Repeated middle clicks on the same position now cycles through all nearby components like requested. Additionally the old info box is shown until the mouse is moved, this gives additional info even when just middle clicking*. It now has a short explanation on top as well, so users don't have to find the osm.org/wiki/JOSM/Advanced_Tricks page to find out what the heck that gray popup is for. The popup allows for toggeling selection now, essentially solving all more complex situations.

Because the popup is useful now, I gave it a small facelift and I added checks to prevent it being drawn off screen on all reasonable testcases.

The code seems to be very fragile, so please check this in with enough time to bake before it's included in a tested release. Especially the colors may need to be checked: Although I chose SystemColor-pairs it might break due to many crappy themes being out there. Also middle clicking doesn't work for me everytime, but I suspect that's due to my scroll settings (see *) and I'm too lazy to restart X :)

  • has the advantage that it only requires a middle click and no "middle press", too. So it works on notebooks that scroll on middle mouse+mouse move. This probably affects 1 user worldwide, including me ;)

comment:4 by stoecker, 15 years ago

Resolution: fixed
Status: newclosed

(In [2109]) applied #3441 - patch by xeen - improve middle click to allow better selections

comment:5 by stoecker, 15 years ago

I think we should fix the black background for selected elements and choose something better, but generally a fine solution I think.

Maybe the user should be able to change colors in color dialog?

by xeen, 15 years ago

The colors depend on your system settings. I've set mine to black, too, but here's a screenshot from Windows in its retro design. Haven't checked for Luna or Glass. Also didn't try for Mac or Linux w/ Gnome or KDE. The colors *should* depend on the theme, though. Or at least on the chosen LookAndFeel in the options dialog.

comment:6 by xeen, 15 years ago

(the first item in the list is selected, the lower white one is being highlighted).

Can anyone on the above mentioned systems/constellations check for color problems?

by stoecker, 15 years ago

Attachment: Screenshot.png added

This is KDE3.5 with Metal as display style. in JOSM

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain xeen.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.