[PATCH] "delete confirmation" message dialogue

[vsandre]

Using the delete mode and moving (not clicking) the mouse over an element which goes outside of the downloaded area causes the delete confirmation message dialogue. This is very annoying.

Using r2044 probably since r2026.

[Gubaer]

Can't reproduce.

What do you mean with "moving"? In can click and "move" or "drag" and I don't get a delete confirmation message.

Lowering priority to normal.

[podolsir]

I could reproduce it with r2026 with r2049. The dialog was shown in response to a mouse hover event over a node. The code in DeleteCommand.delete() is checking whether the delete is real or simulated but does this in the wrong order:

   if (!checkAndConfirmOutlyingDeletes(...) && !simulate)
      return null;

The check and confirm part shows the confirmation dialog which it clearly should do only if we're not simulating (i.e. on clicks only, not on hovers). I'll upload a patch in a second.

[podolsir]

Make the dialog appear iff we're not simulating the delete

[Gubaer]

(In [2054]) applied #3389: patch by podolsir: "delete confirmation" message dialogue
cleanup of ExtendedDialog in DeleteCommand