Opened 16 years ago

Last modified 9 years ago

#3346 closed defect

Validator - fixing duplicate nodes spams with many dialogs — at Version 5

Reported by: bilbo Owned by: team
Priority: normal Milestone: 17.02
Component: Core validator Version: latest
Keywords: Cc: bilbo

Description (last modified by Don-vip)

When I load attached file (it is from OSM where someone accidentally uploaded everything
multiple times) and try to fix this using validator, I run into trouble:

When I select "Duplicate nodes" (there is almost 1000 of them) and press "fix", Validator starts fixing it - unfortunately, many of the duplicate nodes lie outside of downloaded area, so I am flooded with neverending prompts, saying that nodes are outside downloaded area and propting me if I really want to delete them (no, I want to fix only those inside, but I have to click through hundreds of prompts).

This should be solved somehow better with validator (perhaps with one prompt "some nodes are outside downloaded area" -> "fix all of them" / "fix only those inside" / "cancel")

Change History (6)

by anonymous, 16 years ago

Attachment: bad_Kralupy.osm.bz2 added

OSM file with bad data that I tried to fix using Validator

comment:1 by bilbo, 16 years ago

Cc: bilbo added

in reply to:  description comment:2 by anonymous, 16 years ago

Replying to anonymous:

When I load attached file (it is from OSM where someone accidentally uploaded everything
multiple times) and try to fix this using validator, I run into trouble:

When I select "Duplicate nodes" (there is almost 1000 of them) and press "fix", Validator starts fixing it - unfortunately, many of the duplicate nodes lie outside of downloaded area, so I am flooded with neverending prompts, saying that nodes are outside downloaded area and propting me if I really want to delete them (no, I want to fix only those inside, but I have to click through hundreds of prompts).

This should be solved somehow better with validator (perhaps with one prompt "some nodes are outside downloaded area" -> "fix all of them" / "fix only those inside" / "cancel")

In 2561 (current tested) you can disable this dialogue:
settings (F12)
advanced settings (last entry in list)
message.delete_outside_nodes= (empty)
message.delete_outside_nodes.value=1

These settings do not delete the outside_nodes as the value "1" implies!

Last edited 13 years ago by Don-vip (previous) (diff)

comment:3 by HamishB <hamish_b@…>, 16 years ago

for me using the latest testing release (r3208) I still see the errors listed in the validator results box, but when I hit fix it just fixes the downloaded ones it is sure about. no annoying dialog boxes. haven't touched the advanced properties.

so is this one fixed?

Hamish

comment:4 by HamishB <hamish_b@…>, 16 years ago

(it might be nice to get a "x errors not fixed as components are partially out of region" or so message, at fist I couldn't figure out why "Fix" didn't fix them. until I zoomed to one and guessed why)

comment:5 by Don-vip, 13 years ago

Description: modified (diff)
Reporter: changed from anonymous to bilbo
Note: See TracTickets for help on using tickets.