Modify

Opened 9 years ago

Closed 22 months ago

Last modified 22 months ago

#3346 closed defect (fixed)

Validator - fixing duplicate nodes spams with many dialogs

Reported by: bilbo Owned by: team
Priority: normal Milestone: 17.02
Component: Core validator Version: latest
Keywords: Cc: bilbo

Description (last modified by Don-vip)

When I load attached file (it is from OSM where someone accidentally uploaded everything
multiple times) and try to fix this using validator, I run into trouble:

When I select "Duplicate nodes" (there is almost 1000 of them) and press "fix", Validator starts fixing it - unfortunately, many of the duplicate nodes lie outside of downloaded area, so I am flooded with neverending prompts, saying that nodes are outside downloaded area and propting me if I really want to delete them (no, I want to fix only those inside, but I have to click through hundreds of prompts).

This should be solved somehow better with validator (perhaps with one prompt "some nodes are outside downloaded area" -> "fix all of them" / "fix only those inside" / "cancel")

Attachments (1)

bad_Kralupy.osm.bz2 (59.9 KB) - added by anonymous 9 years ago.
OSM file with bad data that I tried to fix using Validator

Download all attachments as: .zip

Change History (15)

Changed 9 years ago by anonymous

Attachment: bad_Kralupy.osm.bz2 added

OSM file with bad data that I tried to fix using Validator

comment:1 Changed 9 years ago by bilbo

Cc: bilbo added

comment:2 in reply to:  description Changed 9 years ago by anonymous

Replying to anonymous:

When I load attached file (it is from OSM where someone accidentally uploaded everything
multiple times) and try to fix this using validator, I run into trouble:

When I select "Duplicate nodes" (there is almost 1000 of them) and press "fix", Validator starts fixing it - unfortunately, many of the duplicate nodes lie outside of downloaded area, so I am flooded with neverending prompts, saying that nodes are outside downloaded area and propting me if I really want to delete them (no, I want to fix only those inside, but I have to click through hundreds of prompts).

This should be solved somehow better with validator (perhaps with one prompt "some nodes are outside downloaded area" -> "fix all of them" / "fix only those inside" / "cancel")

In 2561 (current tested) you can disable this dialogue:
settings (F12)
advanced settings (last entry in list)
message.delete_outside_nodes= (empty)
message.delete_outside_nodes.value=1

These settings do not delete the outside_nodes as the value "1" implies!

Last edited 6 years ago by Don-vip (previous) (diff)

comment:3 Changed 9 years ago by HamishB <hamish_b@…>

for me using the latest testing release (r3208) I still see the errors listed in the validator results box, but when I hit fix it just fixes the downloaded ones it is sure about. no annoying dialog boxes. haven't touched the advanced properties.

so is this one fixed?

Hamish

comment:4 Changed 9 years ago by HamishB <hamish_b@…>

(it might be nice to get a "x errors not fixed as components are partially out of region" or so message, at fist I couldn't figure out why "Fix" didn't fix them. until I zoomed to one and guessed why)

comment:5 Changed 6 years ago by Don-vip

Description: modified (diff)
Reporter: changed from anonymous to bilbo

comment:6 Changed 2 years ago by GerdP

I think this was partly fixed with r10924, see also #13494.

comment:7 Changed 22 months ago by Don-vip

Milestone: 17.02

comment:8 Changed 22 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 11627/josm:

fix #3346 - improve drastically the performance of fixing duplicate nodes by:

  • caching data sources area computation
  • moving layer invalidation from UndoRedoHandler.addNoRedraw to UndoRedoHandler.add
  • avoiding any EDT call when building tag conflict dialog if it's not meant to be displayed

comment:9 Changed 22 months ago by Don-vip

In 11628/josm:

see #3346 - remove debug info committed accidentally

comment:10 Changed 22 months ago by Don-vip

In 11629/josm:

see #3346 - findbugs - IS2_INCONSISTENT_SYNC

comment:11 Changed 22 months ago by Don-vip

In 11630/josm:

see #3346 - update unit test

comment:12 in reply to:  8 Changed 22 months ago by GerdP

Replying to Don-vip:

In 11627/josm:

fix #3346 - improve drastically the performance of fixing duplicate nodes by:

  • caching data sources area computation
  • moving layer invalidation from UndoRedoHandler.addNoRedraw to UndoRedoHandler.add
  • avoiding any EDT call when building tag conflict dialog if it's not meant to be displayed

I wonder if this works when e.g. a plugin modifies the public field Dataset.dataSources. Do you plan to change that to
private?

comment:13 Changed 22 months ago by Don-vip

After updating the plugins, yes. At least PBF and O5M plugins are concerned.

comment:14 Changed 22 months ago by Don-vip

In 11632/josm:

see #3346 - make DataSet.dataSources private

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.