#3346 closed defect (fixed)
Validator - fixing duplicate nodes spams with many dialogs
Reported by: | bilbo | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 17.02 |
Component: | Core validator | Version: | latest |
Keywords: | Cc: | bilbo |
Description (last modified by )
When I load attached file (it is from OSM where someone accidentally uploaded everything
multiple times) and try to fix this using validator, I run into trouble:
When I select "Duplicate nodes" (there is almost 1000 of them) and press "fix", Validator starts fixing it - unfortunately, many of the duplicate nodes lie outside of downloaded area, so I am flooded with neverending prompts, saying that nodes are outside downloaded area and propting me if I really want to delete them (no, I want to fix only those inside, but I have to click through hundreds of prompts).
This should be solved somehow better with validator (perhaps with one prompt "some nodes are outside downloaded area" -> "fix all of them" / "fix only those inside" / "cancel")
Attachments (1)
Change History (15)
Changed 12 years ago by
Attachment: | bad_Kralupy.osm.bz2 added |
---|
comment:1 Changed 11 years ago by
Cc: | bilbo added |
---|
comment:2 Changed 11 years ago by
Replying to anonymous:
When I load attached file (it is from OSM where someone accidentally uploaded everything
multiple times) and try to fix this using validator, I run into trouble:
When I select "Duplicate nodes" (there is almost 1000 of them) and press "fix", Validator starts fixing it - unfortunately, many of the duplicate nodes lie outside of downloaded area, so I am flooded with neverending prompts, saying that nodes are outside downloaded area and propting me if I really want to delete them (no, I want to fix only those inside, but I have to click through hundreds of prompts).
This should be solved somehow better with validator (perhaps with one prompt "some nodes are outside downloaded area" -> "fix all of them" / "fix only those inside" / "cancel")
In 2561 (current tested) you can disable this dialogue:
settings (F12)
advanced settings (last entry in list)
message.delete_outside_nodes= (empty)
message.delete_outside_nodes.value=1
These settings do not delete the outside_nodes as the value "1" implies!
comment:3 Changed 11 years ago by
for me using the latest testing release (r3208) I still see the errors listed in the validator results box, but when I hit fix it just fixes the downloaded ones it is sure about. no annoying dialog boxes. haven't touched the advanced properties.
so is this one fixed?
Hamish
comment:4 Changed 11 years ago by
(it might be nice to get a "x errors not fixed as components are partially out of region" or so message, at fist I couldn't figure out why "Fix" didn't fix them. until I zoomed to one and guessed why)
comment:5 Changed 8 years ago by
Description: | modified (diff) |
---|---|
Reporter: | changed from anonymous to bilbo |
comment:7 Changed 4 years ago by
Milestone: | → 17.02 |
---|
comment:8 follow-up: 12 Changed 4 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
In 11627/josm:
comment:12 Changed 4 years ago by
Replying to Don-vip:
In 11627/josm:
I wonder if this works when e.g. a plugin modifies the public field Dataset.dataSources. Do you plan to change that to
private?
comment:13 Changed 4 years ago by
After updating the plugins, yes. At least PBF and O5M plugins are concerned.
OSM file with bad data that I tried to fix using Validator