[PATCH] Exception when using sort button in edit relations dialog

[anonymous]

Looking at relation no 137,981 (which might be a bit messed up has a lot of memebers marked "incomplete"). Pressed Sort (more or less to see what might happen) and got the exception detailed below.

Path: trunk
URL: ​http://josm.openstreetmap.de/svn/trunk
Repository Root: ​http://josm.openstreetmap.de/svn
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Revision: 1788
Node Kind: directory
Last Changed Author: stoecker
Last Changed Rev: 1788
Last Changed Date: 2009-07-14 18:20:56 +0200 (Tue, 14 Jul 2009)

Memory Usage: 39 MB / 489 MB (6 MB allocated, but free)
Java version: 1.6.0_03

Plugins: measurement
osmarender
slippymap
utilsplugin
wmsplugin
Plugin measurement Version: 16317
Plugin osmarender Version: 16239
Plugin slippymap Version: 16733
Plugin utilsplugin Version: 16290
Plugin wmsplugin Version: 16442

java.lang.NullPointerException

at org.openstreetmap.josm.gui.dialogs.relation.RelationNodeMap.remove(RelationNodeMap.java:99)
at org.openstreetmap.josm.gui.dialogs.relation.GenericRelationEditor.sort(GenericRelationEditor.java:384)
at org.openstreetmap.josm.gui.dialogs.relation.GenericRelationEditor.access$700(GenericRelationEditor.java:106)
at org.openstreetmap.josm.gui.dialogs.relation.GenericRelationEditor$9.actionPerformed(GenericRelationEditor.java:333)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

[Gubaer]

Christiaan, can you have a look at this?

[cjw@…]

The problem occurs when ways other than the first element are incomplete. This was OK in the very first version of the sort feature: nothing happened if any way was incomplete. The current version (in svn) does not generate an exception but drops elements from the relation. The following patch changes the behavior to something else again: incomplete ways are now ignored but other ways and nodes are sorted.

​http://www.time4t.net/~cjw/josm/josm-relation-member-sort-incomplete-ways.patch

[Gubaer]

applied in r1921