Modify

Opened 11 years ago

Closed 6 years ago

Last modified 6 years ago

#3142 closed defect (fixed)

JOSM applet class no longer functional

Reported by: stoecker Owned by: team
Priority: critical Milestone: 14.05
Component: Core Version: latest
Keywords: Cc:

Description

Well, nothing more to say.

Attachments (0)

Change History (18)

comment:1 Changed 11 years ago by Gubaer

See r1879 for a some improvements:

  • no more hacks in the IO subsystem with Sun specific classes
  • catches security exceptions in ImageProvider
  • catches security exceptions in slipply map chooser
  • catches security exceptions when downloading from the API server
  • disables open an save button in the toolbar in applet mode

The applet launches and runs but AFAIK I can't download data unless the applet was loaded from api.openstreetmap.org. How can we get it installed there for testing? Or, initially, at least on api06.dev.openstreetmap.org?

Later we could add an applet parameter for a bounding box and include JOSM as alternative to Potlach in the editor tab on http://www.openstreetmap.org.

comment:2 Changed 11 years ago by stoecker

Are there other bigger issues than the "download data"? We could add a redirect in josm.openstreetmap.de apache and install applet there, so that access is possible. Every data request would go through josm.openstreetmap.org then but I think for testing that is acceptable.

comment:3 Changed 11 years ago by Gubaer

Last time I have been working on it (4 months ago according to this ticket) I was able to start up the applet. I couldn't run additional tests because it wasn't possible to load data.

Configuring josm.openstreetmap.org (not josm.openstreetmap.de?) as reverse proxy is a great idea.

comment:4 Changed 10 years ago by stoecker

Ok. I copied the applet code into download directory and added the api redirect. Following works fine now: josm.openstreetmap.de/api/0.6/capabilities

comment:5 Changed 10 years ago by stoecker

I get an class cast exception when starting. MainApplet cannot be cast to JFrame.

comment:6 Changed 10 years ago by stoecker

The API URL should be changed by the applet class, so it matches the server or passed in applet html code (is this possible?).

comment:7 Changed 10 years ago by stoecker

(In [3239]) some applet fixes

The applet.html now passes api url and links to latest instead of tested (allows better testing of fixes)

http://josm.openstreetmap.de/download/applet.html

comment:8 Changed 10 years ago by stoecker

Now http://josm.openstreetmap.de/applet has been setup, which should be a final destination. Missing is server support for preferences storing and probably a lot of fine tuning.

Also it needs to be decided what arguments may be passed to the applet html code and how they should be handled.

Suggestions welcome.

Anyone willing to write the preferences storage python code.

comment:9 Changed 10 years ago by stoecker

Java improvements:

  • Actually authentication is done by Trac for the applet. So JOSM should first try to get preferences and when this fails ask for username/password. Currently it does the other way round.
  • Loading of failed icons and classes goes to server:
    /META-INF/services/javax.xml.parsers.SAXParserFactory
    /META-INF/services/org.xml.sax.driver
    /images/styles/standard/sport/karting.png
    /images/styles/sport/karting.png
    /images/sport/karting.png
    /images/styles/standard/fixme.png
    /ch/randelshofer/quaqua/QuaquaLookAndFeel.class
    
  • Language detection and loading does not work. Only english is supported ATM.

comment:10 Changed 10 years ago by stoecker

For registered users the applet now gets XML of settings and also puts XML of settings onto server. Probably JOSM code needs to be adapted to handle this correctly. Still missing is a way to use the basic-authentication supplied by the username/password dialog to login onto josm.openstreetmap.de.

comment:11 Changed 10 years ago by stoecker

See #5406.

comment:12 Changed 10 years ago by stoecker

Server now does for /user/preferences:

  • when unauthorized return 401
  • on POST return 200 and the data itself when storing data was ok
  • on GET return 200 and data when data found
  • return 400 when no data found
  • other codes for other errors may exit in future.

comment:13 Changed 10 years ago by stoecker

Priority: majorcritical

Now the server does use the login information of JOSM to login even if TRAC is not logged in.

The applet itself seems to be broken again. it should not ask for OSM login, but for login data to JOSM page. It does so, after the first dialog is closed --> should be other way round.

Also trying to lot motd.html from server should be fixed.

comment:14 in reply to:  13 Changed 8 years ago by skyper

Replying to stoecker:

I tried the applet.

Now the server does use the login information of JOSM to login even if TRAC is not logged in.

The applet itself seems to be broken again. it should not ask for OSM login, but for login data to JOSM page. It does so, after the first dialog is closed --> should be other way round.

Was looged in on TRAC but it worked with OAUTH. Why should it ask for JOSM-PW ?

Also trying to lot motd.html from server should be fixed.

Did work for me.

comment:15 Changed 8 years ago by Don-vip

What's the status of this ? How many users do really use (or try to use) JOSM applet as of 2012 ?

I would be in favour to drop all applet code if there is not a significant number of users. If people want to edit in a web browser, the future is iD, not JOSM applet.

comment:16 in reply to:  15 Changed 8 years ago by bastiK

Replying to Don-vip:

What's the status of this ? How many users do really use (or try to use) JOSM applet as of 2012 ?

I would be in favour to drop all applet code if there is not a significant number of users. If people want to edit in a web browser, the future is iD, not JOSM applet.

Well, iD will probably be awesome, but currently, it is in an early stage of development, whereas the JOSM applet is mostly finished.

I've chatted with TomH some time ago and he was very open to shipping the applet on the main OSM site (as one option in the edit dropdown). The major advantages would be

  • no additional password prompt when you are already logged in on openstreetmap.org
  • more direct access for new users, so less barriers to just try out JOSM

I'd like to see this happen, but wasn't motivated enough so far. :)

comment:17 Changed 6 years ago by stoecker

Resolution: fixed
Status: newclosed

In 7026/josm:

fix #3142 - drop applet code finally

comment:18 Changed 6 years ago by Don-vip

Milestone: 14.05

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.