Modify

Opened 15 years ago

Closed 14 years ago

#3134 closed defect (wontfix)

Download errors not displayed

Reported by: stoecker Owned by: jttt
Priority: minor Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

The progress dialog does not vanish in case of download errors, but also the error message is not displayed.

Test: try downloading a much to large area.

Attachments (2)

down-error.patch (5.8 KB ) - added by plaicy 15 years ago.
produce-error.patch (546 bytes ) - added by plaicy 15 years ago.
Cause an error in josm download.

Download all attachments as: .zip

Change History (5)

comment:1 by jttt, 15 years ago

Resolution: fixed
Status: newclosed

Fixed in r1875

by plaicy, 15 years ago

Attachment: down-error.patch added

by plaicy, 15 years ago

Attachment: produce-error.patch added

Cause an error in josm download.

comment:2 by plaicy, 15 years ago

Priority: majorminor
Resolution: fixed
Status: closedreopened

The error handling while downloading is still fragile. The PleaseWaitDialog may not disappear if an error was thrown. At the moment I have no real User Action to cause this error. But if you apply produce-error.patch a synthetic exception is thrown and JOSM does not catch it correctly.

If this is too academic close this ticket again. I'll open it again if found a user action to cause this error (maybe disturb network connections).

DO NOT INSERT produce-error.patch in SVN....

The problem: The finish function might not be called if after createSubTaskMonitor finishTask for the subTaskMonitor is not called. I tried to correct this (see down-error.patch) but this is not very nice. I think taskFinish of the main ProgressMonitor should in all cases call the doFinish function even if some subtasks are not finished correctly.

comment:3 by Gubaer, 14 years ago

Resolution: wontfix
Status: reopenedclosed

If this is too academic close this ticket again. I'll open it again if found a user action to cause this error (maybe disturb network connections).

I'm closing the ticket for the time being. Please reopen if necessary.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain jttt.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.