Download errors not displayed

[stoecker]

The progress dialog does not vanish in case of download errors, but also the error message is not displayed.

Test: try downloading a much to large area.

[jttt]

Fixed in r1875

[plaicy]

Cause an error in josm download.

[plaicy]

The error handling while downloading is still fragile. The PleaseWaitDialog may not disappear if an error was thrown. At the moment I have no real User Action to cause this error. But if you apply produce-error.patch a synthetic exception is thrown and JOSM does not catch it correctly.

If this is too academic close this ticket again. I'll open it again if found a user action to cause this error (maybe disturb network connections).

DO NOT INSERT produce-error.patch in SVN....

The problem: The finish function might not be called if after createSubTaskMonitor finishTask for the subTaskMonitor is not called. I tried to correct this (see down-error.patch) but this is not very nice. I think taskFinish of the main ProgressMonitor should in all cases call the doFinish function even if some subtasks are not finished correctly.

[Gubaer]

If this is too academic close this ticket again. I'll open it again if found a user action to cause this error (maybe disturb network connections).

I'm closing the ticket for the time being. Please reopen if necessary.