Opened 16 years ago
Closed 15 years ago
#3037 closed enhancement (wontfix)
[PATCH] Invalid maxspeed values...
| Reported by: | delta_foxtrot2 | Owned by: | team |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | Core validator | Version: | |
| Keywords: | Cc: | delta_foxtrot@… |
Description
Going through tagwatch there is a lot of people appending km/h, kph, km/hr etc to metric maxspeeds.
Attachments (2)
Change History (10)
by , 16 years ago
| Attachment: | tagchecker.patch added |
|---|
comment:1 by , 16 years ago
| Cc: | added |
|---|
comment:2 by , 16 years ago
comment:4 by , 16 years ago
Replying to stoecker:
Possibly this?
(\d+( ?mph)?)|walk|city_limits|no
Yes, but doing an inverse match :)
by , 16 years ago
| Attachment: | maxspeed-validator.patch added |
|---|
comment:6 by , 15 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
It is not yet clear what values will be supported in maxspeed and tagwatch doesn't list errors for maxspeed, so I close this as wontfix, as it will do more harm than good.
comment:7 by , 15 years ago
| Resolution: | wontfix |
|---|---|
| Status: | closed → reopened |
Why will this do more harm than good exactly?
According to the wiki maxspeed should be a number, or a number with mph only.
comment:8 by , 15 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | reopened → closed |
Because walk, city_limits and the others you gave are no really used, but DE:urban and other types are. And as currently it is not yet decided how this is handled a check forcing one way or another would be bad. These types probably vanish due to the speed tagging on country relations, but at the moment they are used.
Also there aren't many errors in this value, so this check is not really required.
Now that I think about it, it might be better to do the check against what's valid and error on everything else, however I suck at regex so I can't suggest something better.