Opened 16 years ago
Closed 16 years ago
#3002 closed defect (wontfix)
Save -> NPE
| Reported by: | anonymous | Owned by: | anonymous |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | Core | Version: | |
| Keywords: | Cc: | Gubaer |
Description
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.7.1
Created-By: 14.0-b16 (Sun Microsystems Inc.)
Main-class: JOSM
Main-Version: 1758 SVN
Main-Date: 2009-07-09T17:28:07.102199Z
Memory Usage: 1324 MB / 8183 MB (199 MB allocated, but free)
Java version: 1.6.0_14
Plugins: AgPifoJ
Create_grid_of_ways
DirectUpload
PicLayer
buildings_tools
editgpx
measurement
multipoly
nearclick
openstreetbugs
openvisible
utilsplugin
validator
wmsplugin
Plugin AgPifoJ Version: 16315
Plugin Create_grid_of_ways Version: 16290
Plugin DirectUpload Version: 15828
Plugin PicLayer Version: 16302
Plugin buildings_tools Version: 19
Plugin editgpx Version: 16294
Plugin measurement Version: 16317
Plugin multipoly Version: ${version.entry.commit.revision}
Plugin nearclick Version: 14015
Plugin openstreetbugs Version: 16294
Plugin openvisible Version: 15707
Plugin utilsplugin Version: 16290
Plugin validator Version: 16409
Plugin wmsplugin Version: 16363
java.lang.NullPointerException
at java.util.regex.Pattern.compile(Unknown Source)
at java.util.regex.Pattern.<init>(Unknown Source)
at java.util.regex.Pattern.compile(Unknown Source)
at java.lang.String.split(Unknown Source)
at java.lang.String.split(Unknown Source)
at org.openstreetmap.josm.actions.ExtensionFileFilter.acceptName(ExtensionFileFilter.java:43)
at org.openstreetmap.josm.io.FileImporter.acceptFile(FileImporter.java:20)
at org.openstreetmap.josm.actions.SaveActionBase.save(SaveActionBase.java:154)
at org.openstreetmap.josm.actions.SaveActionBase.save(SaveActionBase.java:143)
at org.openstreetmap.josm.actions.SaveActionBase.doSave(SaveActionBase.java:67)
at org.openstreetmap.josm.actions.SaveActionBase.actionPerformed(SaveActionBase.java:46)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.AbstractButton.doClick(Unknown Source)
at javax.swing.plaf.basic.BasicMenuItemUI.doClick(Unknown Source)
at javax.swing.plaf.basic.BasicMenuItemUI$Handler.menuDragMouseReleased(Unknown Source)
at javax.swing.JMenuItem.fireMenuDragMouseReleased(Unknown Source)
at javax.swing.JMenuItem.processMenuDragMouseEvent(Unknown Source)
at javax.swing.JMenuItem.processMouseEvent(Unknown Source)
at javax.swing.MenuSelectionManager.processMouseEvent(Unknown Source)
at javax.swing.plaf.basic.BasicPopupMenuUI$MouseGrabber.eventDispatched(Unknown Source)
at java.awt.Toolkit$SelectiveAWTEventListener.eventDispatched(Unknown Source)
at java.awt.Toolkit$ToolkitEventMulticaster.eventDispatched(Unknown Source)
at java.awt.Toolkit.notifyAWTEventListeners(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)
Attachments (1)
Change History (8)
comment:1 by , 16 years ago
comment:2 by , 16 years ago
| Cc: | added |
|---|---|
| Owner: | changed from to |
| Status: | new → needinfo |
Your version (Main-Version: 1758 ) is quite old. Could you please update to tested (which is 1788, see http://josm.openstreetmap.org)? Or even to latest (1815 and higher) if you feel comfortable with a JOSM release which might be less stable but for which your feedback would be welcome?
comment:3 by , 16 years ago
I have to agree with reporter, only way I see for this stacktrace to happen is when "," static string becames null. That would be hopefully hardware error, because if there is such a bug in 1.6.0_14 java then it can cause rather big problems.
by , 16 years ago
| Attachment: | extension-file-filter-np-check.patch added |
|---|
comment:4 by , 16 years ago
The first strack trace raise in line 52 in r1975:
for (String ext : extension.split(","))
Naturally this could be caused by ","==null. But I think the real bug is: extension==null
In the current code the stack trace give no reason why extension==null}}. I would suggest checking in constructor (see attached patch). The next time the bug arises, there would be a better bug description. But maybe someone finds why {{{extension==null.
follow-up: 6 comment:5 by , 16 years ago
If extension was null then the stacktrace would end at the line:
org.openstreetmap.josm.actions.ExtensionFileFilter.acceptName(ExtensionFileFilter.java:43)
It gets deeper which means extension is not null. But "," is not null either, because in Pattern constructor is check for pattern length, which would also cause NPE earlier.
Still I have no idea what caused the exception. Pattern has no shared static variables and the exception happend on new instance, so it can't somehow happen that Pattern had broken internal state.
comment:6 by , 16 years ago
Replying to jttt:
If extension was null then the stacktrace would end at the line:
org.openstreetmap.josm.actions.ExtensionFileFilter.acceptName(ExtensionFileFilter.java:43)
Okay. Then you are right. Should be out of scope of josm. Maybe virtual machine or java library or hardware failure. "Memory Usage: 1324 MB / 8183 MB": Maybe something in the 64bit implementation.
comment:7 by , 16 years ago
| Priority: | blocker → major |
|---|---|
| Resolution: | → wontfix |
| Status: | needinfo → closed |
Happend only once, is difficult to reproduce according to the discussion and is very likely caused by hardware/os/java vm => I'd say, that's not a blocker. Since there is consensus that this is out of scope for JOSM, I'm closing it.
PS: After a couple more NPEs in different parts of the application (trying to find a way to save my data), I'd say somehow the static shared string "," got corrupted.
Here are all NPEs I got so far:
java.lang.NullPointerException
java.lang.NullPointerException
java.lang.NullPointerException
java.lang.NullPointerException
java.lang.NullPointerException
java.lang.NullPointerException
java.lang.NullPointerException
java.lang.NullPointerException
java.lang.NullPointerException