Opened 16 years ago
Closed 16 years ago
#2856 closed defect (invalid)
[PATCH] CrossingWays.java incorrectly showing errors
| Reported by: | delta_foxtrot2 | Owned by: | delta_foxtrot2 |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | Core validator | Version: | |
| Keywords: | Cc: | delta_foxtrot@… |
Description
CrossingWays and OverlappingWays select ways like boundary=administrative and treat them like highways and railways and throw warnings as a result.
I'm currently trying to code a patch for this.
Attachments (0)
Change History (7)
comment:1 by , 16 years ago
| Cc: | added |
|---|
comment:2 by , 16 years ago
| Summary: | CrossingWays.java and OverlappingWays.java incorrectly showing errors → [PATCH] CrossingWays.java incorrectly showing errors |
|---|
comment:3 by , 16 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → needinfo |
I'm not sure you're right here. Show an example.
comment:4 by , 16 years ago
A lot of ABS (Australian Bureau of Statistics) boundaries were imported earlier this year, ABS boundaries are for census and other statistic purposes and aren't ways of any sort and shouldn't be treated like a way.
However when you get one of their administrative boundaries crossing ways it's reported as a warning. I'm trying to locate the issue I saw before, I should have included it in the original bug report.
comment:5 by , 16 years ago
If you don't want to exclude all boundaries, a boundary=administrative check would achieve the same thing that the code I posted previously does.
comment:6 by , 16 years ago
Actually the code will not take "boundary" into account at all. There must be another issue which causes this problem.
comment:7 by , 16 years ago
| Resolution: | → invalid |
|---|---|
| Status: | needinfo → closed |
I'm looking over areas I thought this warning was being triggered, but I'm unable to replicate it at the moment, as I said I should have posted the original URL in the ticket, I'll re-open if I find an example.



The overlap error after considering it further is probably valid, however to fix the crossingway error, CrossingWays.java file just needs the following line of code about line 109:
if(es2.ws.way.get("boundary") != null && es2.ws.way.get("highway") == null && railway2 == null && !isCoastline2) continue;