[PATCH] Invalid "Way end node near other way" error

[delta_foxtrot2]

A way that ends with a node being highway=turning_circle close to another way shows an error about a "Way end node near other way" and this isn't correct as the turning circle should indicate the way being final and that it doesn't have to connect to anything.

I'm trying to code a fix for this myself, but I don't fully understand the framework yet and I'm struggling to figure out how this would be solved.

[delta_foxtrot2]

Line 67 of UnconnectedWays.java just needs to following 2 lines of code to fix this issue:

            if(en.get("highway") != null && en.get("highway").equals("turning_circle"))
                continue;

[delta_foxtrot2]

In the case that there isn't a turning circle, noexit=yes should also be considered terminal

            if(en.get("noexit") != null && en.get("noexit").equals("yes"))
                continue;

[delta_foxtrot2]

Testing further there is another corner case, some ways end with a barrier, which in some cases turn into access=private, otherwise they are terminal nodes and shouldn't be connected and shouldn't show a warning about not being connected.

Adding the following code below the above items solves this.

            if(en.get("barrier") != null)
                continue;

[stoecker]

In [o16319]. Boolean checks aren't that easy.

[delta_foxtrot2]

Replying to stoecker:

In [o16319]. Boolean checks aren't that easy.

This is a case of corner cases that haven't been caught previously, this isn't probably not all of them but as I come across others I'll try and work out fixes for them.