[PATCH] Not show an error on junction=roundabout when it is unnamed

[delta_foxtrot2]

I've sort of solved this issue in tests/UntaggedWay.java on line 67

from:

if(highway != null && NAMED_WAYS.contains(highway))

to:

if(highway != null && NAMED_WAYS.contains(highway) && !tags.containsKey("junction"))

[delta_foxtrot2]

I came up with a cleaner solution, although the only official junction currently is a roundabout, a cleaner solution would be to do the following on line 74:

boolean isRoundabout = false;

Then on line 82:

                        if(key.equals("junction"))
                        {
                            isRoundabout = w.get("junction").equals("roundabout");
                            break;
                        }

Finally on line 89, change it from:

if( !hasName )

to:

if( !hasName && !isRoundabout)

[AusRick]

I support the need to remove roundabout junctions from showing as 'unnamed way' errors.

In Australia roundabouts are an incredibly common type of junction, however naming them is done in the rare circumstance that a roundabout has been provided an official name of some kind.

As a result, multiple false-positives occur in any given editing session.

[stoecker]

Im not sure if this is correct. Here in Germany the roundabouts all either have the ref or the name of the corresponding streets.

[delta_foxtrot2]

Replying to stoecker:

Im not sure if this is correct. Here in Germany the roundabouts all either have the ref or the name of the corresponding streets.

I can't comment on what happens in most other countries, I've only been to half a dozen countries and for most of my life I've lived in Australia.

However as ausrick pointed out, in Australia most roundabouts don't have names and they don't have public ref information either, so showing warnings in these cases only generates noise as no information can be filled out for them.

Listing the primary street doesn't really work either as a lot these roundabouts are in residential areas and there is 2 or more streets that are equal to each other, and the mapnik rendering makes them look horrible.

[delta_foxtrot2]

Actually the solution to this is simple, make a new tag warning group that people can ignore, this way those that want to see it can, and those that don't won't and everyone will be happy (if that is even remotely possible) :)

I'll figure out some code for this.

[delta_foxtrot2]

junction.patch.gz

[delta_foxtrot2]

Ok code done, any junction=roundabout makes a new "Unnamed Junction" warning appear instead of "Unnamed Way" which that group can be ignored, without ignoring all unnamed ways.

[stoecker]

In [o16346].

Some notes regarding patches (also for other projects):

• Please don't upload them as gzip if not really necessary. This allows to precheck them in browser
• Please make the diff at least in the make (or ant) directory. patch has a -p option to remove path parts, but no option to add path parts when patching (which means entering path by hand). So longer paths are no problem, but shorter paths are.

[delta_foxtrot2]

validator3.patch

[delta_foxtrot2]

I did the wrong thing slightly and should have created a new error code, sorry about that latest patch fixes the problem I created.

[stoecker]

In [o16434].