Modify

Opened 17 years ago

Closed 16 years ago

#2705 closed enhancement (fixed)

[PATCH] Adding initial elemstyles for public_transport

Reported by: Claudius Owned by: ulfl
Priority: minor Milestone:
Component: Internal mappaint style Version:
Keywords: Cc:

Description

Added some style support for:
public_transport:stop_position (node only; reusing tramstop)
public_transport:entrance (node only; reusing subway_entrance)
public_transport:platform (node + line; new icon + new dashed line feature)

Attachments (2)

public_transport_elemstyles.diff (1.7 KB ) - added by Claudius 17 years ago.
platform.png (1.1 KB ) - added by Claudius 17 years ago.
To be put in \images\styles\standard\transport

Download all attachments as: .zip

Change History (7)

by Claudius, 17 years ago

by Claudius, 17 years ago

Attachment: platform.png added

To be put in \images\styles\standard\transport

comment:1 by stoecker, 17 years ago

The dir images/styles/standard is part of OSM SVN. I fear there are different requirements there - at least different sizes as well as a base SVG probably.

I wont checkin anything there - Ulf?

comment:2 by ulfl, 17 years ago

Status: newassigned

Hi Claudius, first of all thanks for the patch!

According to tagwatch, until today only stop_position (703), platform (614) and stop_area (216) are actually used in a reasonable amount. I personally hesitate to add rules for things that appear less than ~100 times in the planet (rules can be easily added later on).

If we want to add new icons, we have to be clear about the icons license (PD appreciated)! Anyway, both an SVG version and a 16*16 png are highly appreciated (but only the png is really mandatory for JOSM).

Maybe it's easiest to add the corresponding rules first (using blank icons) and add the right icons later on.

I didn't followed the public transport discussions too closely, so I'm not very familiar with the public_transport tags - could you add a link to a page describing the tags (this way I can get an idea what this is all about :-).

Regards, ULFL

comment:3 by ulfl, 17 years ago

Owner: changed from ulfl to Claudius
Status: assignedneedinfo

comment:4 by Claudius, 17 years ago

Owner: changed from Claudius to ulfl
Status: needinfonew

More details on the proposed new public transport scheme:
http://wiki.openstreetmap.org/wiki/User:Oxomoa/Public_transport_schema

Forgot to mention the licence: I pixeled the new platform icon myself and it's PD. Will try to do an SVG version as well. Going with the rules first and adding icons later is fine, but actually i could reuse loads of existing ones and just had to create a new one for platforms.

comment:5 by ulfl, 16 years ago

Resolution: fixed
Status: newclosed

I've added rules for stop_position and platform in SVN 1723.

As the platform tag is used for all kinds of transport (e.g. even funicular!), I think your "bus specific" icon is just too specific and therefore misleading. Unfortunately, I don't have a good idea for a better one.

I tend to keep the blank icons for now.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain ulfl.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.