Modify

Opened 11 years ago

Closed 11 years ago

#2645 closed defect (fixed)

[PATCH] Reversing multiple ways that are members of the same relation is broken

Reported by: Teemu Koskinen <teemu.koskinen@…> Owned by: team
Priority: minor Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

This patch fixes reversing multiple ways that are members of the same relation, and have a role that needs to be changed by ReverseWayTagCorrector. Only the role of the way that was reversed last was saved, as all the changes were made to a state before any of the reversing took place.

The fix was to introduce a new command, ChangeRelationMemberRoleCommand, that only takes the relation, the position of the member, and the new role and changes the relation without making a whole new copy of the relation. This makes it possible to make many modifications to a relation's members roles without executing them at each step (which would make using undo hard).

Attachments (1)

rolecorrection2.diff (4.9 KB) - added by Teemu Koskinen <teemu.koskinen@…> 11 years ago.

Download all attachments as: .zip

Change History (2)

Changed 11 years ago by Teemu Koskinen <teemu.koskinen@…>

Attachment: rolecorrection2.diff added

comment:1 Changed 11 years ago by stoecker

Resolution: fixed
Status: newclosed

In r1617.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.