Modify

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#2643 closed enhancement (fixed)

[PATCH] Better linkedness support for relation editor

Reported by: Teemu Koskinen <teemu.koskinen@…> Owned by: team
Priority: minor Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

This patch adds support for forwards/backwards roles in route relations to show the linkedness of the ways. It also skips over any nodes and relations that don't have any ways as members.

If the first way has role forward, only the last node will be considered, and if backward, then only the first node is considered, otherwise both are.

Similarily, if the second way has role forward, only the first node will be considered, and if backward, then only the last node is considered, otherwise both are.

If the member is the last way, or it is a node, or a relation that doesn't contain any ways, then the linkedness column will be empty.

Attachments (2)

linkedmembers.diff (4.0 KB ) - added by Teemu Koskinen <teemu.koskinen@…> 15 years ago.
linkedmembers2.diff (3.9 KB ) - added by Teemu Koskinen <teemu.koskinen@…> 15 years ago.
Updated patch

Download all attachments as: .zip

Change History (5)

by Teemu Koskinen <teemu.koskinen@…>, 15 years ago

Attachment: linkedmembers.diff added

by Teemu Koskinen <teemu.koskinen@…>, 15 years ago

Attachment: linkedmembers2.diff added

Updated patch

comment:1 by stoecker, 15 years ago

Resolution: fixed
Status: newclosed

In r1618.

As you seem to be interested in route relations. Maybe you can make on "order relation" button. The code to draw multipolygons already has a function which joins ways at their end points. Maybe that would be helpful.

in reply to:  1 comment:2 by Teemu Koskinen <teemu.koskinen@…>, 15 years ago

Replying to stoecker:

As you seem to be interested in route relations. Maybe you can make on "order relation" button. The code to draw multipolygons already has a function which joins ways at their end points. Maybe that would be helpful.

I've been thinking about that, but it needs some more thought still.

There are few cases that make the ordering difficult:

  • circular routes, where to start?
  • alternative segments and/or one-way segments
  • missing segments

comment:3 by stoecker, 15 years ago

See the code I mentioned. It has the same problems :-)

  • circular ways - use the start way you find first as start way
  • alternative segments or missing segments-produce as many linked groups as possible. Let the user do the rest

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.