[Patch] Missing error message when API initialization fails

[anonymous]

Path: trunk
URL: ​http://josm.openstreetmap.de/svn/trunk
Repository Root: ​http://josm.openstreetmap.de/svn
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Revision: 1594
Node Kind: directory
Last Changed Author: stoecker
Last Changed Rev: 1594
Last Changed Date: 2009-05-15 22:22:21 +0200 (Fri, 15 May 2009)

Java version: 1.6.0_13
Plugins: DirectUpload;editgpx;openstreetbugs;openvisible;utilsplugin;validator;wmsplugin
Plugin DirectUpload Version: 14856
Plugin editgpx Version: 14247
Plugin openstreetbugs Version: 14826
Plugin openvisible Version: 14233
Plugin utilsplugin Version: 14356
Plugin validator Version: 14406
Plugin wmsplugin Version: 14885

java.lang.RuntimeException: java.lang.NullPointerException

at org.openstreetmap.josm.gui.PleaseWaitRunnable$4.run(PleaseWaitRunnable.java:119)
at java.awt.event.InvocationEvent.dispatch(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

Caused by: java.lang.NullPointerException

at org.openstreetmap.josm.io.OsmApi.modifyPrimitive(OsmApi.java:244)
at org.openstreetmap.josm.io.OsmServerWriter.makeApiRequest(OsmServerWriter.java:135)
at org.openstreetmap.josm.io.OsmServerWriter.uploadOsm(OsmServerWriter.java:113)
at org.openstreetmap.josm.actions.UploadAction$2.realRun(UploadAction.java:183)
at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:101)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)

Console output:
GET ​http://www.openstreetmap.org/api/capabilities... GET ​http://www.openstreetma
p.org/api/capabilities... GET ​http://www.openstreetmap.org/api/capabilities... G
ET ​http://www.openstreetmap.org/api/capabilities... GET ​http://www.openstreetmap
.org/api/capabilities... GET ​http://www.openstreetmap.org/api/capabilities... or
g.openstreetmap.josm.io.OsmTransferException: connect timed out java.net.SocketT
imeoutException

at org.openstreetmap.josm.io.OsmApi.sendRequest(OsmApi.java:532)
at org.openstreetmap.josm.io.OsmApi.initialize(OsmApi.java:136)
at org.openstreetmap.josm.io.OsmServerWriter.uploadOsm(OsmServerWriter.j

ava:70)

at org.openstreetmap.josm.actions.UploadAction$2.realRun(UploadAction.ja

va:183)

at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.

java:101)

at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source

)

at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)

Caused by: java.net.SocketTimeoutException: connect timed out

at java.net.PlainSocketImpl.socketConnect(Native Method)
at java.net.PlainSocketImpl.doConnect(Unknown Source)
at java.net.PlainSocketImpl.connectToAddress(Unknown Source)
at java.net.PlainSocketImpl.connect(Unknown Source)
at java.net.SocksSocketImpl.connect(Unknown Source)
at java.net.Socket.connect(Unknown Source)
at sun.net.NetworkClient.doConnect(Unknown Source)
at sun.net.www.http.HttpClient.openServer(Unknown Source)
at sun.net.www.http.HttpClient.openServer(Unknown Source)
at sun.net.www.http.HttpClient.<init>(Unknown Source)
at sun.net.www.http.HttpClient.New(Unknown Source)
at sun.net.www.http.HttpClient.New(Unknown Source)
at sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(Unknown

Source)

at sun.net.www.protocol.http.HttpURLConnection.plainConnect(Unknown Sour

ce)

at sun.net.www.protocol.http.HttpURLConnection.connect(Unknown Source)
at org.openstreetmap.josm.io.OsmApi.sendRequest(OsmApi.java:479)
... 7 more

Defaults for osm-server.atomic-upload differ: false != true
java.lang.RuntimeException: java.lang.NullPointerException

at org.openstreetmap.josm.gui.PleaseWaitRunnable$4.run(PleaseWaitRunnabl

e.java:119)

at java.awt.event.InvocationEvent.dispatch(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

Caused by: java.lang.NullPointerException

at org.openstreetmap.josm.io.OsmApi.modifyPrimitive(OsmApi.java:244)
at org.openstreetmap.josm.io.OsmServerWriter.makeApiRequest(OsmServerWri

ter.java:135)

at org.openstreetmap.josm.io.OsmServerWriter.uploadOsm(OsmServerWriter.j

ava:113)

at org.openstreetmap.josm.actions.UploadAction$2.realRun(UploadAction.ja

va:183)

at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.

java:101)

at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source

)

at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)

[anonymous]

I tried again without errors.
Maybe the server was busy.

[Gubaer]

Probably your internet connection was interrupted or the server was busy/down for a short time.

Caused by: java.net.SocketTimeoutException: connect timed out

JOSM could have warned you more cleary, though. See attachment:2633.patch​ for a patch.

[stoecker]

In r1608.